[wesnoth-commits] [wesnoth/wesnoth] 4eee38: Stop passing a milion game_config refs around duri...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 4eee386664b66e801bd4498e8730c017af03f0aa
      https://github.com/wesnoth/wesnoth/commit/4eee386664b66e801bd4498e8730c017af03f0aa
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-06-25 (Mon, 25 Jun 2018)

  Changed paths:
    M src/controller_base.cpp
    M src/controller_base.hpp
    M src/editor/controller/editor_controller.cpp
    M src/editor/controller/editor_controller.hpp
    M src/editor/editor_main.cpp
    M src/editor/editor_main.hpp
    M src/game_initialization/lobby_data.cpp
    M src/game_initialization/lobby_data.hpp
    M src/game_initialization/lobby_info.cpp
    M src/game_initialization/lobby_info.hpp
    M src/game_initialization/multiplayer.cpp
    M src/game_initialization/multiplayer.hpp
    M src/game_initialization/playcampaign.cpp
    M src/game_initialization/playcampaign.hpp
    M src/game_launcher.cpp
    M src/menu_events.cpp
    M src/menu_events.hpp
    M src/play_controller.cpp
    M src/play_controller.hpp
    M src/playmp_controller.cpp
    M src/playmp_controller.hpp
    M src/playsingle_controller.cpp
    M src/playsingle_controller.hpp

  Log Message:
  -----------
  Stop passing a milion game_config refs around during game initializaton

There are only 3 places where it's actually really needed. Used the game_config_manager
singleton to retrieve a reference in those cases.


  Commit: feb99c384a3da58380697bfcf9ad18bc57df950f
      https://github.com/wesnoth/wesnoth/commit/feb99c384a3da58380697bfcf9ad18bc57df950f
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-06-25 (Mon, 25 Jun 2018)

  Changed paths:
    M src/game_initialization/configure_engine.cpp
    M src/gui/dialogs/game_ui.cpp
    M src/gui/dialogs/multiplayer/faction_select.cpp

  Log Message:
  -----------
  Cleaned up a few game_config_manager.hpp includes


Compare: https://github.com/wesnoth/wesnoth/compare/11ca2d8ad833...feb99c384a3d
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.