[wesnoth-commits] [wesnoth/wesnoth] 690a9d: wmllint: Leave gzipped binary files alone, they're...

[GitHub]

  Branch: refs/heads/1.14
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 690a9de9480fbb81c0f309bcd9c4ece2f4d81311
      https://github.com/wesnoth/wesnoth/commit/690a9de9480fbb81c0f309bcd9c4ece2f4d81311
  Author: Iris Morelle <shadowm at wesnoth.org>
  Date:   2018-06-27 (Wed, 27 Jun 2018)

  Changed paths:
    M changelog.md
    M data/tools/wesnoth/wmltools3.py

  Log Message:
  -----------
  wmllint: Leave gzipped binary files alone, they're not safe for consumption

Fixes wmllint crashing like this upon encountering a gzip tarball in an
add-on:

  Traceback (most recent call last):
    File "/home/shadowm/bin/wmllint-1.14", line 3188, in <module>
      for fn in allcfgfiles(directory):
    File "/home/shadowm/bin/wmllint-1.14", line 2944, in allcfgfiles
      if interesting(os.path.join(root, name)):
    File "/home/shadowm/bin/wmllint-1.14", line 2927, in interesting
      return fn.endswith(".cfg") or is_map(fn) or issave(fn)
    File "/home/shadowm/src/wesnoth-1.14/data/tools/wesnoth/wmltools3.py", line 270, in issave
      return firstline.startswith("label=")
  TypeError: startswith first arg must be bytes or a tuple of bytes, not str

[ci skip]



      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.