[wesnoth-commits] [wesnoth/wesnoth] a3a969: Cleaned up unnecessary inclusion of formula/string...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: a3a9697d14820d15353f5558d4cb3b8dc9f84ac6
      https://github.com/wesnoth/wesnoth/commit/a3a9697d14820d15353f5558d4cb3b8dc9f84ac6
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-03-03 (Sat, 03 Mar 2018)

  Changed paths:
    M src/addon/manager.cpp
    M src/editor/map/editor_map.cpp
    M src/editor/palette/terrain_palettes.cpp
    M src/game_initialization/create_engine.cpp
    M src/game_initialization/depcheck.cpp
    M src/generators/default_map_generator_job.cpp
    M src/gui/dialogs/network_transmission.cpp
    M src/minimap.cpp
    M src/mp_game_settings.cpp
    M src/playmp_controller.cpp
    M src/save_index.cpp
    M src/team.cpp
    M src/teambuilder.cpp
    M src/tod_manager.cpp

  Log Message:
  -----------
  Cleaned up unnecessary inclusion of formula/string_utils.hpp

These were either not needed, or serialization/string_utils.hpp was desired instead.


  Commit: b2ad732f75382afd516c91a7bf9fd97c9b85ed3e
      https://github.com/wesnoth/wesnoth/commit/b2ad732f75382afd516c91a7bf9fd97c9b85ed3e
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-03-03 (Sat, 03 Mar 2018)

  Changed paths:
    M src/map/location.cpp
    M src/map/location.hpp

  Log Message:
  -----------
  Map/Location: removed explicit inlining of various functions

I'm told it's better to let the compiler make a determination as to whether to inline
something instead of doing it manually. A few of these looked like they were probably
marked inline simple to have the implementation in the header, and a few were static
functions with inline implementations, which doesn't make much sense at all...


Compare: https://github.com/wesnoth/wesnoth/compare/7bb4977ceeba...b2ad732f7538