[wesnoth-commits] [wesnoth/wesnoth] 574bfb: MP Join Game: removed unnecessary event context wh...

GitHub noreply at github.com
Sun Mar 4 14:24:23 UTC 2018


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 574bfbca188b4536e0ac368fdb315508a14ec955
      https://github.com/wesnoth/wesnoth/commit/574bfbca188b4536e0ac368fdb315508a14ec955
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-03-05 (Mon, 05 Mar 2018)

  Changed paths:
    M src/gui/dialogs/multiplayer/mp_join_game.cpp

  Log Message:
  -----------
  MP Join Game: removed unnecessary event context when prompting faction selection

This was a holdover from the old GUI1 dialog code, IIRC. It's not needed with GUI2, and is
probably the reason I had that weird issue where I couldn't call this function (fetch_game_config)
from mp_join_game::pre_show. However, even if that were the case, the current design is
perfectly acceptable.




More information about the Commits mailing list