[wesnoth-commits] [wesnoth/wesnoth] abf932: Don't source steps/script.sh.

GitHub noreply at github.com
Sun Mar 4 21:48:02 UTC 2018


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: abf93216acd73a507d3edab87469056d7dbd480a
      https://github.com/wesnoth/wesnoth/commit/abf93216acd73a507d3edab87469056d7dbd480a
  Author: pentarctagon <pentarctagon at tutamail.com>
  Date:   2018-03-04 (Sun, 04 Mar 2018)

  Changed paths:
    M .travis.yml
    M utils/travis/docker_run.sh
    M utils/travis/steps/script.sh

  Log Message:
  -----------
  Don't source steps/script.sh.

Travis runs all commands in .travis.yml in its own wrapper script, so by sourcing steps/script.sh and then using exit explicitly, it resulted in the entire travis wrapper immediately terminating.  With steps/script.sh no longer sourced, using exit works as expected again, and only exits steps/script.sh rather than quitting everything. Another solution, should sourcing steps/script.sh become necessary, is to use return instead of exit.

With that addressed, it's then possible to re-add printing the ccache statistics after the build ends while also making sure that the script exits with the return code of the xcodebuild/cmake+make command rather than the return code of the ccache statistics commands.




More information about the Commits mailing list