[wesnoth-commits] [wesnoth/wesnoth] 19cd31: Don't assume unit is on the map when testing abili...

[GitHub]

  Branch: refs/heads/fix_2247
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 19cd31e6fd15587f5119541e16c958bcd00126be
      https://github.com/wesnoth/wesnoth/commit/19cd31e6fd15587f5119541e16c958bcd00126be
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-03-04 (Sun, 04 Mar 2018)

  Changed paths:
    M src/actions/attack.cpp
    M src/gui/dialogs/attack_predictions.cpp
    M src/reports.cpp
    M src/units/abilities.cpp
    M src/units/attack_type.hpp

  Log Message:
  -----------
  Don't assume unit is on the map when testing ability active

This refactors ability tests to use a passed-in unit instead of
searching for the unit on the map based on its location.

While it does fix #2247, I am not confident that this won't also
have some undesirable side-effects.


  Commit: 00b93054c996e9e02646759e106741a3e74e71f1
      https://github.com/wesnoth/wesnoth/commit/00b93054c996e9e02646759e106741a3e74e71f1
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-03-04 (Sun, 04 Mar 2018)

  Changed paths:
    M src/actions/attack.cpp
    M src/gui/dialogs/attack_predictions.cpp
    M src/reports.cpp
    M src/units/abilities.cpp
    M src/units/attack_type.hpp

  Log Message:
  -----------
  Use RAII for weapon specials context to ensure no dangling pointers


  Commit: 2c8b90521c87e6d247ef8df5721bf39d06fb3e2c
      https://github.com/wesnoth/wesnoth/commit/2c8b90521c87e6d247ef8df5721bf39d06fb3e2c
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-03-04 (Sun, 04 Mar 2018)

  Changed paths:
    M src/actions/attack.cpp

  Log Message:
  -----------
  Fix an obvious-looking error in attack action


Compare: https://github.com/wesnoth/wesnoth/compare/6b4aef9b7517...2c8b90521c87