[wesnoth-commits] [wesnoth/wesnoth] dabf09: Fix deprecation spam

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: dabf09fce1d71fbac4b0b798df1f4c8ea9dc9487
      https://github.com/wesnoth/wesnoth/commit/dabf09fce1d71fbac4b0b798df1f4c8ea9dc9487
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-03-04 (Sun, 04 Mar 2018)

  Changed paths:
    M data/ai/lua/patrol.lua
    M data/lua/core.lua
    M data/lua/wml-tags.lua
    M src/deprecation.cpp
    M src/deprecation.hpp
    M src/log.cpp
    M src/log.hpp
    M src/scripting/lua_common.cpp
    M src/scripting/lua_common.hpp
    M src/scripting/lua_kernel_base.cpp

  Log Message:
  -----------
  Fix deprecation spam

This removes the Lua deprecation_message function in favour of exposing the C++ variant to Lua instead.
It also moves all deprecation messages to a separate logdomain, making them easily enabled en masse.


  Commit: 401f88d0e0c0ac96ecfedf2037739d3143d629b6
      https://github.com/wesnoth/wesnoth/commit/401f88d0e0c0ac96ecfedf2037739d3143d629b6
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-03-04 (Sun, 04 Mar 2018)

  Changed paths:
    M src/gui/dialogs/log_settings.cpp

  Log Message:
  -----------
  Fix crash in logging prefs due to deprecation's default -1 severity


  Commit: 624d8e03e182083760de4530aa3c227755fc0ca4
      https://github.com/wesnoth/wesnoth/commit/624d8e03e182083760de4530aa3c227755fc0ca4
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-03-04 (Sun, 04 Mar 2018)

  Changed paths:
    M src/commandline_options.cpp

  Log Message:
  -----------
  Add --log-none command line option to disable ALL output from a logdomain


  Commit: dc0d6474e888dddafbd9995857bb9cdbe5efa20b
      https://github.com/wesnoth/wesnoth/commit/dc0d6474e888dddafbd9995857bb9cdbe5efa20b
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-03-04 (Sun, 04 Mar 2018)

  Changed paths:
    M src/game_config.cpp
    M src/game_config.hpp
    M src/game_launcher.cpp
    M src/help/help_impl.cpp
    M src/help/help_impl.hpp
    M src/menu_events.cpp
    M src/wesnoth.cpp

  Log Message:
  -----------
  Boost deprecation logdomain severity when debug mode is enabled


  Commit: 32b6a3de4534a8f5bff8ab97fe8d722313596d39
      https://github.com/wesnoth/wesnoth/commit/32b6a3de4534a8f5bff8ab97fe8d722313596d39
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-03-04 (Sun, 04 Mar 2018)

  Changed paths:
    M data/advanced_preferences.cfg
    M src/deprecation.cpp

  Log Message:
  -----------
  Add hidden preference to show deprecation messages in chat area

In 1.15 the preference will be added to the advanced preferences pane.


  Commit: 5fc9d8d1739576302fc6da9c90c13cbffd0f023b
      https://github.com/wesnoth/wesnoth/commit/5fc9d8d1739576302fc6da9c90c13cbffd0f023b
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-03-04 (Sun, 04 Mar 2018)

  Changed paths:
    M data/lua/wml/message.lua
    M src/actions/unit_creator.cpp
    M src/ai/lua/core.cpp
    M src/config.cpp
    M src/config.hpp
    M src/game_config.cpp
    M src/game_events/menu_item.cpp
    M src/generators/cave_map_generator.cpp
    M src/generators/default_map_generator_job.cpp
    M src/gui/auxiliary/old_markup.cpp
    M src/gui/auxiliary/old_markup.hpp
    M src/gui/dialogs/campaign_difficulty.cpp
    M src/gui/dialogs/multiplayer/faction_select.cpp
    M src/gui/dialogs/multiplayer/mp_options_helper.cpp
    M src/scripting/game_lua_kernel.cpp
    M src/scripting/lua_gui2.cpp
    M src/storyscreen/parser.cpp
    M src/units/abilities.cpp
    M src/units/unit.cpp
    M src/version.hpp
    M src/wml_exception.hpp

  Log Message:
  -----------
  Use new deprecated_message() function wherever possible (C++)

This also covers handling of legacy DescriptionWML for [set_menu_item],
and tweaks its handling in the other cases (mainly [multiplayer_side]).

I added the next_dev_version constant intending to use it, but then
decided not to do so; however I left it in in case someone finds it useful.


  Commit: 1e2512a67220195d1c0ae366013d97e1106b0d23
      https://github.com/wesnoth/wesnoth/commit/1e2512a67220195d1c0ae366013d97e1106b0d23
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-03-04 (Sun, 04 Mar 2018)

  Changed paths:
    M data/lua/wml-tags.lua

  Log Message:
  -----------
  Honour the regular deprecation message settings for WML deprecation messages


  Commit: b0559eb0bf20e45b4b7482dabd302b5df4662e62
      https://github.com/wesnoth/wesnoth/commit/b0559eb0bf20e45b4b7482dabd302b5df4662e62
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-03-04 (Sun, 04 Mar 2018)

  Changed paths:
    M src/actions/unit_creator.cpp
    M src/ai/lua/core.cpp
    M src/config.cpp
    M src/deprecation.cpp
    M src/deprecation.hpp
    M src/game_events/menu_item.cpp
    M src/gui/auxiliary/old_markup.cpp
    M src/gui/dialogs/campaign_difficulty.cpp
    M src/gui/dialogs/multiplayer/mp_options_helper.cpp
    M src/scripting/game_lua_kernel.cpp
    M src/scripting/lua_kernel_base.cpp
    M src/serialization/preprocessor.cpp
    M src/serialization/preprocessor.hpp
    M src/storyscreen/parser.cpp
    M src/units/abilities.cpp
    M src/units/unit.cpp

  Log Message:
  -----------
  Use an enum for deprecation levels (C++ only)

This is not done for Lua and WML due to some complications.
It could still be done for them later, if desired.


  Commit: b02e73535e9aeede609b9393158b6600f2013964
      https://github.com/wesnoth/wesnoth/commit/b02e73535e9aeede609b9393158b6600f2013964
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-03-04 (Sun, 04 Mar 2018)

  Changed paths:
    M projectfiles/VC12/wesnoth.vcxproj
    M projectfiles/VC12/wesnoth.vcxproj.filters
    M projectfiles/VC12/wesnothlib.vcxproj
    M projectfiles/VC12/wesnothlib.vcxproj.filters
    M src/campaign_server/campaign_server.cpp
    M src/server/server.cpp
    M src/server/server_base.cpp

  Log Message:
  -----------
  Fix wesnothd and campaignd link errors


Compare: https://github.com/wesnoth/wesnoth/compare/5517063fb9cb...b02e73535e9a