[wesnoth-commits] [wesnoth/wesnoth] c64c6f: fix no_leader having no effect (#2606)

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: c64c6f513aeb2037669ec35987f74edf5c9c7247
      https://github.com/wesnoth/wesnoth/commit/c64c6f513aeb2037669ec35987f74edf5c9c7247
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2018-03-07 (Wed, 07 Mar 2018)

  Changed paths:
    M src/game_initialization/flg_manager.cpp
    M src/game_initialization/flg_manager.hpp

  Log Message:
  -----------
  fix no_leader having no effect (#2606)

fix no_leader having no effect

fixes #2604

it previously only worked if both leader_lock and no_leader were set to yes. Now it the type= is preserved if any of the two are given, the difference bewteen those two is that no_leader only works is type= is empty. 

this also fixes some wrong parameternames in the the flg_manager ctor declaration.

This commit does not change the default value for those keys: no_leader default to yes in [side]s in [scenario] but not in multiplayer. While leader_lock defaults to the force_lock_settings key in [scenario]/[multiuplayer]