[wesnoth-commits] [wesnoth/wesnoth] 7eff74: GUI2/Modal Dialog, Modeless Dialog: made window_ a...

GitHub noreply at github.com
Mon Mar 12 02:30:33 UTC 2018


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 7eff742fbaca7c7b029ed185dd85ba3ca9051709
      https://github.com/wesnoth/wesnoth/commit/7eff742fbaca7c7b029ed185dd85ba3ca9051709
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-03-12 (Mon, 12 Mar 2018)

  Changed paths:
    M src/gui/dialogs/modal_dialog.hpp
    M src/gui/dialogs/modeless_dialog.hpp

  Log Message:
  -----------
  GUI2/Modal Dialog, Modeless Dialog: made window_ a protected class member

This will allow direct use of the window pointer without binding in hundreds of different
callbacks just because we want to use it for, say, find_widget.

This is just the base change. I still might change my mind as to this method, and I have
yet to undertake any refactoring around this.

modal_dialog::get_window and modeless_dialog::get_window remain.




More information about the Commits mailing list