[wesnoth-commits] [wesnoth/wesnoth] a3c46d: Upgrade to PHP 5.6.27 bcrypt

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: a3c46d363925a4738893f01e26aad77075089aef
      https://github.com/wesnoth/wesnoth/commit/a3c46d363925a4738893f01e26aad77075089aef
  Author: Gregory A Lundberg <gregory_lundberg at gmx.com>
  Date:   2018-03-13 (Tue, 13 Mar 2018)

  Changed paths:
    M source_lists/libwesnoth_core
    R src/bcrypt/COPYING
    R src/bcrypt/README
    R src/bcrypt/bcrypt.c
    R src/bcrypt/bcrypt.h
    R src/bcrypt/crypt_blowfish.md
    R src/bcrypt/crypt_blowfish/LINKS
    R src/bcrypt/crypt_blowfish/PERFORMANCE
    R src/bcrypt/crypt_blowfish/README
    R src/bcrypt/crypt_blowfish/crypt.h
    R src/bcrypt/crypt_blowfish/crypt_blowfish.c
    R src/bcrypt/crypt_blowfish/crypt_blowfish.h
    R src/bcrypt/crypt_blowfish/crypt_gensalt.c
    R src/bcrypt/crypt_blowfish/crypt_gensalt.h
    R src/bcrypt/crypt_blowfish/ow-crypt.h
    R src/bcrypt/crypt_blowfish/wrapper.c
    A src/crypt_blowfish/crypt_blowfish.c
    A src/crypt_blowfish/crypt_blowfish.h
    A src/crypt_blowfish/crypt_blowfish.md
    M src/hash.cpp
    M src/hash.hpp

  Log Message:
  -----------
  Upgrade to PHP 5.6.27 bcrypt

Valid through PHP 7.2.2, at least.

Switch to the PHP-specific version of crypt_blowfish. Eliminate libbcrypt as dead/redundant code.


  Commit: 0407ee40ac9bf0feeae306ec769323dbb7c2f3c6
      https://github.com/wesnoth/wesnoth/commit/0407ee40ac9bf0feeae306ec769323dbb7c2f3c6
  Author: Gregory A Lundberg <gregory_lundberg at gmx.com>
  Date:   2018-03-13 (Tue, 13 Mar 2018)

  Changed paths:
    M src/hash.cpp

  Log Message:
  -----------
  Allow all official forms of bcrypt supported by PHP

Tested with $2a$, $2b$, $2x$ and $2y$. Also tested $2a$ converted to $2x$, and $2b$ converted to $2y$.

In addition, tested handling of short salt values (terminated with $), as supported by PHP as a hack (including PHP's bugs, as embodied in crypt_blowfish.c).


  Commit: 4c77b5c418359256e2dcd73d535c8fd7e269a18c
      https://github.com/wesnoth/wesnoth/commit/4c77b5c418359256e2dcd73d535c8fd7e269a18c
  Author: Gregory A Lundberg <gregory_lundberg at gmx.com>
  Date:   2018-03-13 (Tue, 13 Mar 2018)

  Changed paths:
    M src/game_initialization/multiplayer.cpp
    M src/server/server.cpp
    M src/server/user_handler.cpp
    M src/server/user_handler.hpp

  Log Message:
  -----------
  Use cryptographic-strength RNG for password nonce

rand() and srand() are crap.

We can't fix the existing MD5 password hashing but it will go away when Bcrypt password hashing goes live on the Forums.


  Commit: 8d951d9f5db493dd6022c31737faf433ffa28d49
      https://github.com/wesnoth/wesnoth/commit/8d951d9f5db493dd6022c31737faf433ffa28d49
  Author: lundberg <gregory_lundberg at gmx.com>
  Date:   2018-03-13 (Tue, 13 Mar 2018)

  Changed paths:
    M projectfiles/VC12/wesnothlib.vcxproj

  Log Message:
  -----------
  Update VS projectfile for crypt_blowfish changes


  Commit: c861a54369c456e2a0568a8eb53e97a7ad332b72
      https://github.com/wesnoth/wesnoth/commit/c861a54369c456e2a0568a8eb53e97a7ad332b72
  Author: Sofartin <hrubymar10 at gmail.com>
  Date:   2018-03-13 (Tue, 13 Mar 2018)

  Changed paths:
    M projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj

  Log Message:
  -----------
  Fixed Xcode project


  Commit: 108f6188abeaca93d499db5d206bd3b882062da1
      https://github.com/wesnoth/wesnoth/commit/108f6188abeaca93d499db5d206bd3b882062da1
  Author: Gregory A Lundberg <gregory_lundberg at gmx.com>
  Date:   2018-03-13 (Tue, 13 Mar 2018)

  Changed paths:
    M src/server/forum_user_handler.cpp
    M src/server/forum_user_handler.hpp
    M src/server/sample_user_handler.hpp
    M src/server/server.cpp
    M src/server/user_handler.cpp
    M src/server/user_handler.hpp

  Log Message:
  -----------
  Use standard names

The word salt was used to mean both the password salt and the password challenge nonce.

The word pepper was used to represent the password challenge.

Also renamed the MD5 nonce generator to make it clear it's not secure.


  Commit: d577b3a35fa5e9d85f48f587d5087b838110886b
      https://github.com/wesnoth/wesnoth/commit/d577b3a35fa5e9d85f48f587d5087b838110886b
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2018-03-13 (Tue, 13 Mar 2018)

  Changed paths:
    M projectfiles/VC12/wesnothd.vcxproj

  Log Message:
  -----------
  Visual Studio: link wesnothd.exe to libeay32.lib

Fixes build of wesnothd with VS.


  Commit: 67ff2257fd0f7a8c492793895c1039b9b7e3baa7
      https://github.com/wesnoth/wesnoth/commit/67ff2257fd0f7a8c492793895c1039b9b7e3baa7
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2018-03-13 (Tue, 13 Mar 2018)

  Changed paths:
    M src/server/user_handler.cpp

  Log Message:
  -----------
  Use std::array instead of traditional C array


  Commit: 7dbe554f6c429d1553e3cf248b61b250bac7bba1
      https://github.com/wesnoth/wesnoth/commit/7dbe554f6c429d1553e3cf248b61b250bac7bba1
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2018-03-13 (Tue, 13 Mar 2018)

  Changed paths:
    M src/server/server.cpp

  Log Message:
  -----------
  Change a ternary to a single line

Without the comments, it's short enough to fit into a single line.


  Commit: dc40b783e1175823610d83e0a3b449fe74473d4e
      https://github.com/wesnoth/wesnoth/commit/dc40b783e1175823610d83e0a3b449fe74473d4e
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2018-03-13 (Tue, 13 Mar 2018)

  Changed paths:
    M projectfiles/VC12/campaignd.vcxproj
    M projectfiles/VC12/wesnoth.vcxproj
    M projectfiles/VC12/wesnothd.vcxproj
    M projectfiles/VC12/wesnothlib.vcxproj
    M projectfiles/VC12/wesnothlib.vcxproj.filters

  Log Message:
  -----------
  Suppress Boost's warnings about unrecognized Visual Studio version

Visual Studio auto-updates so often that we can't keep up by updating
Boost every time. It's easier to just suppress the warnings instead.


Compare: https://github.com/wesnoth/wesnoth/compare/2d6392adc394...dc40b783e117