[wesnoth-commits] [wesnoth/wesnoth] f80fab: Help: removed code to show old GUI1 help browser

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: f80fabfe304032aa78cb93ef6be2ed6a04d95f59
      https://github.com/wesnoth/wesnoth/commit/f80fabfe304032aa78cb93ef6be2ed6a04d95f59
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-03-20 (Tue, 20 Mar 2018)

  Changed paths:
    M src/help/help.cpp
    M src/help/help.hpp

  Log Message:
  -----------
  Help: removed code to show old GUI1 help browser

Attempting to launch it crashes the game (probably to do with a null video surface),
and since it's being replaced there's no point in restoring it to functionality.

The implementation details (help_menu, etc) have been left for now. Will remove soon.

This also means the GUI2 help browser is shown by default now.


  Commit: 504d4d2ff4de18ab0d69b089a9a8ae65a91dea70
      https://github.com/wesnoth/wesnoth/commit/504d4d2ff4de18ab0d69b089a9a8ae65a91dea70
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-03-20 (Tue, 20 Mar 2018)

  Changed paths:
    M src/display.cpp
    M src/display.hpp

  Log Message:
  -----------
  Display: removed now-unused map_screenshot_surface_

Unused as of 3a768cbdbe5d. It was needed for get_screen_surface(), which is used in
drawing_queue, but that's going to be removed soon.


  Commit: 123dd952c05a15a0e9d179de2fae0b81ad34ddd3
      https://github.com/wesnoth/wesnoth/commit/123dd952c05a15a0e9d179de2fae0b81ad34ddd3
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-03-20 (Tue, 20 Mar 2018)

  Changed paths:
    M src/video.hpp

  Log Message:
  -----------
  Made CVideo::render_screen private

It's not supposed to be called outside events::pump.


Compare: https://github.com/wesnoth/wesnoth/compare/77f2c758ca71...123dd952c05a