[wesnoth-commits] [wesnoth/wesnoth] 15db51: gui/mp: Fix two strings not being translated in th...

[GitHub]

  Branch: refs/heads/1.14
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 15db5181cfe9a0f6fa7dd2c24bc74bded77099d8
      https://github.com/wesnoth/wesnoth/commit/15db5181cfe9a0f6fa7dd2c24bc74bded77099d8
  Author: Iris Morelle <shadowm at wesnoth.org>
  Date:   2018-03-23 (Fri, 23 Mar 2018)

  Changed paths:
    M data/gui/macros/custom_options_tree.cfg
    M data/gui/macros/player_list_panel.cfg

  Log Message:
  -----------
  gui/mp: Fix two strings not being translated in the UI

This is caused by a broken assumption on wmlxgettext's part. Because the
files did not have a textdomain directive anywhere, the translatable
strings in them were assigned to the wesnoth textdomain. The game engine
seems to have a different idea though, and includes them in an
unidentified textdomain that may or may not be wesnoth-lib, as per the
last #textdomain directive seen in the combined WML for the
data/gui/macros directory substitution.

This merits further examination of the preprocessor's code (and
wmlxgettext's logic), but for now this is a simple patch that fixes the
issue without breaking the string freeze or introducing any potential
regressions.

This fixes two particular strings mentioned in issue #2709:

 * "There are no custom options available for the selected era, game, or modification."
 * "Connected Players"

Vultraz made a similar fix in commit
8d1ec6216bb336f29f5e213df5b1418703cdc0a0 in master, but it breaks the
string freeze by virtue of moving the strings across textdomains.

[ci skip]