[wesnoth-commits] [wesnoth/wesnoth] edd7a8: pull remote user input even if we are doing a loca...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: edd7a82255e6ec7d8882900e0df56fb3af853436
      https://github.com/wesnoth/wesnoth/commit/edd7a82255e6ec7d8882900e0df56fb3af853436
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2018-03-31 (Sat, 31 Mar 2018)

  Changed paths:
    M src/synced_user_choice.cpp

  Log Message:
  -----------
  pull remote user input even if we are doing a local choice.

this mainly effects wesnoth.synchronize_choices:
previously the client would not process incoming choices from other
players while it was exeucting its own local choice (usually a dialog).
The problem this commit fixes is that with the old behaviour any choice
from another player would block the incoming queue, in particular
chatmessages after that command would be delayed until the
wesnoth.synchronize_choices is finished.


  Commit: bce8c29568a0ba28455579e0057180f00bdd9190
      https://github.com/wesnoth/wesnoth/commit/bce8c29568a0ba28455579e0057180f00bdd9190
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2018-03-31 (Sat, 31 Mar 2018)

  Changed paths:
    M src/replay.cpp

  Log Message:
  -----------
  treat local choices as like sycned contexts in replay.cpp

this makes more sense as the game cannot handle sycned commands while
executing local choices. It also fixes an OOS in
wesnoth.synchronize_choices


  Commit: 9593062fc65eb1769ebdab16ed4b1d380e6aaa69
      https://github.com/wesnoth/wesnoth/commit/9593062fc65eb1769ebdab16ed4b1d380e6aaa69
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2018-03-31 (Sat, 31 Mar 2018)

  Changed paths:
    M src/synced_user_choice.cpp

  Log Message:
  -----------
  guard against calling user_choice_manager::pull() recursively


Compare: https://github.com/wesnoth/wesnoth/compare/a32d689c46a2...9593062fc65e