[wesnoth-commits] [wesnoth/wesnoth] 639cf2: wb: fix nullptr assertion when log is enabled

[GitHub]

  Branch: refs/heads/1.14
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 639cf20a738c5ba7dd137e7ca8250733d8a33e98
      https://github.com/wesnoth/wesnoth/commit/639cf20a738c5ba7dd137e7ca8250733d8a33e98
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2018-05-03 (Thu, 03 May 2018)

  Changed paths:
    M src/whiteboard/move.cpp

  Log Message:
  -----------
  wb: fix nullptr assertion when log is enabled


  Commit: b6e8a5b91db3093bed6fd8a6eefbf67f054f5035
      https://github.com/wesnoth/wesnoth/commit/b6e8a5b91db3093bed6fd8a6eefbf67f054f5035
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2018-05-03 (Thu, 03 May 2018)

  Changed paths:
    M src/whiteboard/attack.cpp
    M src/whiteboard/move.cpp
    M src/whiteboard/move.hpp
    M src/whiteboard/side_actions.cpp
    M src/whiteboard/side_actions.hpp

  Log Message:
  -----------
  wb: refactor out get_unit() calls

there have been reported many assertion failures due to get_unit()
returning nullptr, so we try not to rely on get_unit() whenever
possible.


  Commit: 729d6b6fc282b639effd4a48182949ed019f5f72
      https://github.com/wesnoth/wesnoth/commit/729d6b6fc282b639effd4a48182949ed019f5f72
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2018-05-03 (Thu, 03 May 2018)

  Changed paths:
    M src/menu_events.cpp
    M src/menu_events.hpp
    M src/whiteboard/move.cpp
    M src/whiteboard/move.hpp
    M src/whiteboard/recruit.cpp
    M src/whiteboard/side_actions.cpp
    M src/whiteboard/side_actions.hpp

  Log Message:
  -----------
  wb: update following moves when a recruit is executed

After a recruit action was executed the id of the unit was changed so we
need to update the unitid of all following actions on that unit


  Commit: 5412a24b05a9f8b89db0a2734ab77a46a7e19f66
      https://github.com/wesnoth/wesnoth/commit/5412a24b05a9f8b89db0a2734ab77a46a7e19f66
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2018-05-03 (Thu, 03 May 2018)

  Changed paths:
    M src/whiteboard/manager.cpp

  Log Message:
  -----------
  wb: fix crash when using planning mode mode with dsu

fixes #1599 . we now automaticllay disable dsu when enabling planning mode


  Commit: 05ab8e275fd9557d17661451a10345256fc15ea6
      https://github.com/wesnoth/wesnoth/commit/05ab8e275fd9557d17661451a10345256fc15ea6
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2018-05-03 (Thu, 03 May 2018)

  Changed paths:
    M src/whiteboard/manager.cpp

  Log Message:
  -----------
  wb: cleanups & add debug message


  Commit: 576bdea529c198cc0f030b5bf3493c5745bcbf18
      https://github.com/wesnoth/wesnoth/commit/576bdea529c198cc0f030b5bf3493c5745bcbf18
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2018-05-03 (Thu, 03 May 2018)

  Changed paths:
    M src/whiteboard/attack.cpp

  Log Message:
  -----------
  wb: add debug info


  Commit: 0745eb94a396e292fc83a3bb60107347c800f22f
      https://github.com/wesnoth/wesnoth/commit/0745eb94a396e292fc83a3bb60107347c800f22f
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2018-05-03 (Thu, 03 May 2018)

  Changed paths:
    M src/whiteboard/action.hpp
    M src/whiteboard/highlighter.cpp
    M src/whiteboard/manager.cpp
    M src/whiteboard/move.hpp

  Log Message:
  -----------
  wb: fix moves for planned recruits

the for those moves get_unit() might return nullptr when it is
when the future map is not applied and some codes deduced from
that that the action is invalid. So we make sure that code does
not rely on get_unit().


Compare: https://github.com/wesnoth/wesnoth/compare/a7018d06ffe3...0745eb94a396
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.