[wesnoth-commits] [wesnoth/wesnoth] 18e5ea: i18n: Blind fix attempt for std::bad_cast being th...

[GitHub]

  Branch: refs/heads/1.14
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 18e5ea50a7136cb3686c5a7c51c111ccce73dc54
      https://github.com/wesnoth/wesnoth/commit/18e5ea50a7136cb3686c5a7c51c111ccce73dc54
  Author: Iris Morelle <shadowm at wesnoth.org>
  Date:   2018-05-06 (Sun, 06 May 2018)

  Changed paths:
    M src/gettext_boost.cpp

  Log Message:
  -----------
  i18n: Blind fix attempt for std::bad_cast being thrown on Windows

Several reports on Steam and our forums point at std::bad_cast being
thrown when accessing Preferences and the Multiplayer menu amongst
others. It's possible that the locale configuration on those systems is
not quite right, and compare() and icompare() are able to throw
std::bad_cast when this happens as they both use std::use_facet().

Note that much like the macOS/iOS version of icompare(), this stopgap
patch doesn't attempt to provide any form of case-insensitive fallback
and just uses a case-sensitive comparison instead.



      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.