[wesnoth-commits] [wesnoth/wesnoth] 871189: i18n: Blind fix attempt for std::bad_cast being th...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 871189cc3680880243b0c6b6f1af78ba9819be4d
      https://github.com/wesnoth/wesnoth/commit/871189cc3680880243b0c6b6f1af78ba9819be4d
  Author: Iris Morelle <shadowm at wesnoth.org>
  Date:   2018-05-07 (Mon, 07 May 2018)

  Changed paths:
    M src/gettext_boost.cpp

  Log Message:
  -----------
  i18n: Blind fix attempt for std::bad_cast being thrown on Windows

Several reports on Steam and our forums point at std::bad_cast being
thrown when accessing Preferences and the Multiplayer menu amongst
others. It's possible that the locale configuration on those systems is
not quite right, and compare() and icompare() are able to throw
std::bad_cast when this happens as they both use std::use_facet().

Note that much like the macOS/iOS version of icompare(), this stopgap
patch doesn't attempt to provide any form of case-insensitive fallback
and just uses a case-sensitive comparison instead.


  Commit: 057e53a4631fdf0aa90ab2d1c37f74b8b4ed1839
      https://github.com/wesnoth/wesnoth/commit/057e53a4631fdf0aa90ab2d1c37f74b8b4ed1839
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2018-05-07 (Mon, 07 May 2018)

  Changed paths:
    M src/gettext_boost.cpp

  Log Message:
  -----------
  Partial case insensitivity for translation::icompare() fallback


Compare: https://github.com/wesnoth/wesnoth/compare/26c8860b6c12...057e53a4631f
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.