[wesnoth-commits] [wesnoth/wesnoth] a76135: Revert "MP Lobby: reduced frequency of network pol...

[GitHub]

  Branch: refs/heads/1.14
  Home:   https://github.com/wesnoth/wesnoth
  Commit: a76135d107bb370ab18ccc1b06018e3b2f494003
      https://github.com/wesnoth/wesnoth/commit/a76135d107bb370ab18ccc1b06018e3b2f494003
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-05-09 (Wed, 09 May 2018)

  Changed paths:
    M src/game_config.cpp

  Log Message:
  -----------
  Revert "MP Lobby: reduced frequency of network polls (100ms -> 1000ms)"

This reverts commit 5fd833a91af57df3134e4e87a1d36b23c2811652. It was causing the lobby to
lag up to *three minutes* behind current activity due to multiple data packets being queued
(see #3046). It seems 100 ms was enough to mask this issue.


  Commit: c95eb016849190b9bda87ef2d893cf7777ac5d10
      https://github.com/wesnoth/wesnoth/commit/c95eb016849190b9bda87ef2d893cf7777ac5d10
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-05-09 (Wed, 09 May 2018)

  Changed paths:
    M changelog.md
    M src/game_initialization/connect_engine.cpp

  Log Message:
  -----------
  Fixed a crash when using certain invalid color= values

The specific case that brought this to our attention was color=100. In case such values
are used, the color reverts back to the default color for that side, as before.

The new codepath (team::get_side_color_id_from_config) is essentially the same as the old
one but more robust (range checking, for example, the lack of which was causing the crash
before).


Compare: https://github.com/wesnoth/wesnoth/compare/db463517799e...c95eb0168491
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.