[wesnoth-commits] [wesnoth/wesnoth] 1c575f: Work around some weird compiler bug with VS using ...

GitHub noreply at github.com
Fri May 11 05:11:30 UTC 2018


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 1c575f59fa16029247c6d05c5e5f7b74cafdc26e
      https://github.com/wesnoth/wesnoth/commit/1c575f59fa16029247c6d05c5e5f7b74cafdc26e
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-05-11 (Fri, 11 May 2018)

  Changed paths:
    M src/gui/core/event/dispatcher_private.hpp

  Log Message:
  -----------
  Work around some weird compiler bug with VS using C++17

Without this, I get the error "syntax error: '<'" and a reference to the function's
opening bracket... No idea why. It build fine on VS 15.7.1 with C++14.


  Commit: f279ad5fc0f83ee946ab75049994fdbbd0ca18d5
      https://github.com/wesnoth/wesnoth/commit/f279ad5fc0f83ee946ab75049994fdbbd0ca18d5
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-05-11 (Fri, 11 May 2018)

  Changed paths:
    M src/movetype.cpp
    M src/whiteboard/manager.cpp

  Log Message:
  -----------
  Whiteboard: avoid the use of a deprecated C++17 function

shared_ptr::unique() is equivalent to use_count() == 1. A few of these checks should probably
be > 1 to account for 0, but this is a direct logical translation.


Compare: https://github.com/wesnoth/wesnoth/compare/0f9a0fac5eb4...f279ad5fc0f8
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the Commits mailing list