[wesnoth-commits] [wesnoth/wesnoth] 60b112: Mark wml_exception::show const and formula_ai::han...

[GitHub]

  Branch: refs/heads/1.14
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 60b1124d8bf351b1935f38392a8ec4f16f32e2c8
      https://github.com/wesnoth/wesnoth/commit/60b1124d8bf351b1935f38392a8ec4f16f32e2c8
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-05-13 (Sun, 13 May 2018)

  Changed paths:
    M src/ai/formula/ai.cpp
    M src/ai/formula/ai.hpp
    M src/wml_exception.cpp
    M src/wml_exception.hpp

  Log Message:
  -----------
  Mark wml_exception::show const and formula_ai::handle_exception's argument const


  Commit: 0bf09c82a51b7a1e0ba414ffb59dbcebda1c3340
      https://github.com/wesnoth/wesnoth/commit/0bf09c82a51b7a1e0ba414ffb59dbcebda1c3340
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-05-13 (Sun, 13 May 2018)

  Changed paths:
    M src/actions/attack.cpp
    M src/actions/undo.cpp
    M src/addon/client.cpp
    M src/addon/manager_ui.cpp
    M src/ai/actions.cpp
    M src/ai/composite/component.cpp
    M src/ai/composite/goal.cpp
    M src/ai/configuration.cpp
    M src/ai/formula/ai.cpp
    M src/ai/formula/candidates.cpp
    M src/ai/formula/stage_unit_formulas.cpp
    M src/campaign_server/campaign_server.cpp
    M src/commandline_options.cpp
    M src/config_cache.cpp
    M src/display.cpp
    M src/editor/controller/editor_controller.cpp
    M src/editor/editor_main.cpp
    M src/editor/map/context_manager.cpp
    M src/editor/map/editor_map.cpp
    M src/editor/map/map_context.cpp
    M src/filesystem_boost.cpp
    M src/font/font_config.cpp
    M src/formula/formula.cpp
    M src/formula/variant_value.hpp
    M src/game_config.cpp
    M src/game_config_manager.cpp
    M src/game_events/action_wml.cpp
    M src/game_initialization/create_engine.cpp
    M src/game_initialization/lobby_data.cpp
    M src/game_initialization/lobby_info.cpp
    M src/game_initialization/multiplayer.cpp
    M src/game_initialization/playcampaign.cpp
    M src/game_initialization/singleplayer.cpp
    M src/game_launcher.cpp
    M src/generators/cave_map_generator.cpp
    M src/generators/default_map_generator.cpp
    M src/generators/lua_map_generator.cpp
    M src/gettext_boost.cpp
    M src/gui/dialogs/advanced_graphics_options.cpp
    M src/gui/dialogs/editor/custom_tod.cpp
    M src/gui/dialogs/game_load.cpp
    M src/gui/dialogs/lua_interpreter.cpp
    M src/gui/dialogs/multiplayer/lobby.cpp
    M src/gui/dialogs/preferences_dialog.cpp
    M src/gui/dialogs/story_viewer.hpp
    M src/gui/dialogs/title_screen.cpp
    M src/gui/dialogs/tooltip.cpp
    M src/gui/gui.cpp
    M src/gui/widgets/minimap.cpp
    M src/gui/widgets/size_lock.cpp
    M src/gui/widgets/window.cpp
    M src/halo.cpp
    M src/image.cpp
    M src/image_modifications.cpp
    M src/language.cpp
    M src/language.hpp
    M src/lexical_cast.hpp
    M src/map/label.cpp
    M src/map/location.cpp
    M src/map/map.cpp
    M src/menu_events.cpp
    M src/mouse_events.cpp
    M src/persist_context.cpp
    M src/playmp_controller.cpp
    M src/playsingle_controller.cpp
    M src/preferences/credentials.cpp
    M src/preferences/general.cpp
    M src/replay.cpp
    M src/save_blocker.cpp
    M src/save_index.cpp
    M src/savegame.cpp
    M src/scripting/game_lua_kernel.cpp
    M src/scripting/lua_kernel_base.cpp
    M src/serialization/preprocessor.cpp
    M src/serialization/schema_validator.cpp
    M src/serialization/string_utils.cpp
    M src/serialization/unicode.cpp
    M src/serialization/unicode_cast.hpp
    M src/server/ban.cpp
    M src/server/forum_user_handler.cpp
    M src/server/game.cpp
    M src/server/server.cpp
    M src/server/simple_wml.cpp
    M src/side_filter.cpp
    M src/statistics.cpp
    M src/synced_commands.cpp
    M src/terrain/builder.cpp
    M src/terrain/filter.cpp
    M src/terrain/translation.cpp
    M src/tests/gui/test_gui2.cpp
    M src/tests/test_make_enum.cpp
    M src/tod_manager.cpp
    M src/units/abilities.cpp
    M src/units/attack_type.cpp
    M src/units/filter.cpp
    M src/units/frame_private.hpp
    M src/units/unit.cpp
    M src/variable.cpp
    M src/wesnoth.cpp
    M src/whiteboard/move.cpp
    M src/whiteboard/side_actions.cpp

  Log Message:
  -----------
  Catch all exceptions (where possible) as const references

A few catch blocks modify something in their exceptions, so those are kept non-const.


Compare: https://github.com/wesnoth/wesnoth/compare/b8c305a286e5...0bf09c82a51b
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.