[wesnoth-commits] [wesnoth/wesnoth] c5ba6f: Cleaned up utils::apply_modifier a bit

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: c5ba6f01a824d4ec633930ceb8f3dceef2f2d435
      https://github.com/wesnoth/wesnoth/commit/c5ba6f01a824d4ec633930ceb8f3dceef2f2d435
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-05-28 (Mon, 28 May 2018)

  Changed paths:
    M src/serialization/string_utils.cpp

  Log Message:
  -----------
  Cleaned up utils::apply_modifier a bit


  Commit: ed8a8a48f70174dae128afbdb07b1488b5a8d1d9
      https://github.com/wesnoth/wesnoth/commit/ed8a8a48f70174dae128afbdb07b1488b5a8d1d9
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-05-28 (Mon, 28 May 2018)

  Changed paths:
    M src/config.cpp
    M src/filesystem.cpp
    M src/formula/function.cpp
    M src/gui/dialogs/wml_error.cpp
    M src/preferences/credentials.cpp
    M src/scripting/lua_kernel_base.cpp
    M src/units/unit.cpp
    M src/utils/markov_generator.cpp

  Log Message:
  -----------
  Used std::string::front() and back() in more places


  Commit: 40d9b9953b8556b06462405da0a4fa564aa16e0b
      https://github.com/wesnoth/wesnoth/commit/40d9b9953b8556b06462405da0a4fa564aa16e0b
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-05-28 (Mon, 28 May 2018)

  Changed paths:
    M src/actions/attack.cpp
    M src/actions/create.cpp
    M src/actions/move.cpp
    M src/actions/undo.cpp
    M src/actions/vision.cpp
    M src/display.cpp
    M src/display.hpp
    M src/editor/map/context_manager.cpp
    M src/game_display.cpp
    M src/hotkey/command_executor.cpp
    M src/play_controller.cpp
    M src/playsingle_controller.cpp
    M src/playturn.cpp
    M src/replay.cpp
    M src/replay_controller.cpp
    M src/scripting/game_lua_kernel.cpp
    M src/synced_commands.cpp

  Log Message:
  -----------
  Cleaned up some unused stuff from the display class

Namely complete_redraw_event(), recalculate_minimap(), and redraw_minimap(). I had
been keeping the last around for reference (see f5ec886cb5dd083302b0f33daaaec19574963c68) but I
figure it's not really worth it since this isn't the drawing method we'll want to
be using in the end anyway.


Compare: https://github.com/wesnoth/wesnoth/compare/0ca822795903...40d9b9953b85
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.