[wesnoth-commits] [wesnoth/wesnoth] 53126f: Mouse events: don't keep around references to figh...

[GitHub]

  Branch: refs/heads/1.14
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 53126f685645da7cc018faf32a4f7b741b7e5e97
      https://github.com/wesnoth/wesnoth/commit/53126f685645da7cc018faf32a4f7b741b7e5e97
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2018-11-02 (Fri, 02 Nov 2018)

  Changed paths:
    M src/mouse_events.cpp
    M src/mouse_events.hpp

  Log Message:
  -----------
  Mouse events: don't keep around references to fighting units

Keeping references is bad if a unit dies and the dying unit has a halo
and a long-running listener for the "last breath" event, like in AtS E2
S10. In that case keeping the reference means that the halo will remain
as long as the event runs.

Closes #3673.



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.