[wesnoth-commits] [wesnoth/wesnoth] 2dfe3f: clientside fix for #3717 : oos for allies caused b...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 2dfe3f24b4ffda06d88b23f1a80c9a8149361342
      https://github.com/wesnoth/wesnoth/commit/2dfe3f24b4ffda06d88b23f1a80c9a8149361342
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2018-11-27 (Tue, 27 Nov 2018)

  Changed paths:
    M src/playturn.cpp

  Log Message:
  -----------
  clientside fix for #3717 : oos for allies caused by planned recruits

a servesided fix was already pushed, both fixes fix the issue independly: the issue will only appae when none of there fixes are present in the curent game.

The probem was that the wb network handler preiously might create units and the unit ctor would wrongly assumes it was in a synced context which messed up the unit id counter. I asume this happend because turn_info::process_network_data was called during the play_slice calls during an animation loop to process chat messages but actually received wb data.



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.