[wesnoth-commits] [wesnoth/wesnoth] 57070f: Saved Game: reame "starting pos" to "starting poin...

GitHub noreply at github.com
Sun Oct 7 13:44:19 UTC 2018


  Branch: refs/heads/1.14
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 57070f230408532089a7af70f2b28badf1c96a01
      https://github.com/wesnoth/wesnoth/commit/57070f230408532089a7af70f2b28badf1c96a01
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-10-07 (Sun, 07 Oct 2018)

  Changed paths:
    M src/game_initialization/configure_engine.cpp
    M src/game_initialization/mp_game_utils.cpp
    M src/game_initialization/multiplayer.cpp
    M src/game_initialization/playcampaign.cpp
    M src/playsingle_controller.cpp
    M src/saved_game.cpp
    M src/saved_game.hpp
    M src/savegame.cpp
    M src/savegame.hpp
    M src/tests/test_mp_connect.cpp

  Log Message:
  -----------
  Saved Game: reame "starting pos" to "starting point" to avoid confusion

The old name was too easy to confuse with a side's map staring position, something
I've done several times.

Backport for less merging conflics


  Commit: e23a95c287a8a477cc35c248034201154da6603b
      https://github.com/wesnoth/wesnoth/commit/e23a95c287a8a477cc35c248034201154da6603b
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-10-07 (Sun, 07 Oct 2018)

  Changed paths:
    M src/config.cpp
    M src/filesystem_boost.cpp
    M src/formula/function.cpp
    M src/gui/dialogs/wml_error.cpp
    M src/preferences/credentials.cpp
    M src/scripting/lua_kernel_base.cpp
    M src/units/unit.cpp
    M src/utils/markov_generator.cpp

  Log Message:
  -----------
  Used std::string::front() and back() in more places


  Commit: ea611b52d756d4400b07fcdfc100799247883612
      https://github.com/wesnoth/wesnoth/commit/ea611b52d756d4400b07fcdfc100799247883612
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2018-10-07 (Sun, 07 Oct 2018)

  Changed paths:
    M src/formula/function.cpp

  Log Message:
  -----------
  fix out of bonunds check


  Commit: fc6ff0c25d58c6486eb1f796fe88c39602a2287c
      https://github.com/wesnoth/wesnoth/commit/fc6ff0c25d58c6486eb1f796fe88c39602a2287c
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-10-07 (Sun, 07 Oct 2018)

  Changed paths:
    M src/controller_base.cpp
    M src/editor/controller/editor_controller.cpp
    M src/editor/map/context_manager.cpp
    M src/editor/palette/editor_palettes.cpp
    M src/game_events/action_wml.cpp
    M src/game_events/wmi_manager.cpp
    M src/gui/dialogs/addon/manager.cpp
    M src/gui/dialogs/campaign_selection.cpp
    M src/gui/dialogs/multiplayer/faction_select.cpp
    M src/gui/dialogs/multiplayer/mp_create_game.cpp
    M src/gui/dialogs/multiplayer/mp_staging.cpp
    M src/hotkey/hotkey_handler.cpp
    M src/theme.cpp

  Log Message:
  -----------
  Cleaned up unnecessary instances of emplace_back(config {})

No need to invoke the copy ctor.


  Commit: ecaef55d0c64145bffc4ce9522ed860a0d7f98d4
      https://github.com/wesnoth/wesnoth/commit/ecaef55d0c64145bffc4ce9522ed860a0d7f98d4
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-10-07 (Sun, 07 Oct 2018)

  Changed paths:
    M src/units/animation.cpp

  Log Message:
  -----------
  Unit/Animation: emplace_back (mostly) ahoy

Three cases could not use emplace_back since the ctor they use is private... :(
Which sucks since unit_animation looks like it'd be a bit expensive to copy.


  Commit: 3d953aa2f051cb694ac0e1f1b07570444c27bb04
      https://github.com/wesnoth/wesnoth/commit/3d953aa2f051cb694ac0e1f1b07570444c27bb04
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-10-07 (Sun, 07 Oct 2018)

  Changed paths:
    M src/ai/formula/function_table.cpp
    M src/campaign_server/campaign_server.cpp
    M src/formula/function.cpp
    M src/gui/dialogs/lua_interpreter.cpp
    M src/scripting/game_lua_kernel.cpp
    M src/wesnoth.cpp

  Log Message:
  -----------
  Used UNUSED macro instead of (void) where applicable


  Commit: d60da99b5f12c1e0155069e5a87aa10803fbe783
      https://github.com/wesnoth/wesnoth/commit/d60da99b5f12c1e0155069e5a87aa10803fbe783
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-10-07 (Sun, 07 Oct 2018)

  Changed paths:
    M src/ai/composite/aspect.hpp
    M src/ai/composite/engine.hpp
    M src/ai/composite/property_handler.hpp
    M src/ai/composite/rca.hpp
    M src/ai/formula/engine_fai.cpp
    M src/ai/formula/function_table.cpp

  Log Message:
  -----------
  AI: deployed std::make_shared in a whole bunch of places

Also simplified a few instance of shared_ptr assignment. No need to create a temp ptr
just to immediately assign them.


  Commit: f6372830c1c4a9e909ced547f51a9d39eeae41c7
      https://github.com/wesnoth/wesnoth/commit/f6372830c1c4a9e909ced547f51a9d39eeae41c7
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-10-07 (Sun, 07 Oct 2018)

  Changed paths:
    M src/ai/composite/engine.hpp
    M src/ai/composite/goal.hpp
    M src/ai/composite/stage.hpp
    M src/ai/default/aspect_attacks.cpp
    M src/ai/default/recruitment.cpp
    M src/ai/formula/ai.cpp
    M src/ai/formula/engine_fai.cpp
    M src/formula/formula.cpp
    M src/game_events/wmi_manager.cpp
    M src/hotkey/hotkey_item.cpp
    M src/tests/test_rng.cpp

  Log Message:
  -----------
  Deployed std::make_shared in more places

backport of 'Deployed std::make_unique and std::make_shared in more places'


  Commit: 90518b645ca08f832f2ff01d817bd87b43ec23ce
      https://github.com/wesnoth/wesnoth/commit/90518b645ca08f832f2ff01d817bd87b43ec23ce
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-10-07 (Sun, 07 Oct 2018)

  Changed paths:
    M src/gui/core/register_widget.hpp
    M src/gui/widgets/addon_list.cpp
    M src/gui/widgets/addon_list.hpp
    M src/gui/widgets/button.cpp
    M src/gui/widgets/button.hpp
    M src/gui/widgets/chatbox.cpp
    M src/gui/widgets/chatbox.hpp
    M src/gui/widgets/drawing.cpp
    M src/gui/widgets/drawing.hpp
    M src/gui/widgets/horizontal_scrollbar.cpp
    M src/gui/widgets/horizontal_scrollbar.hpp
    M src/gui/widgets/image.cpp
    M src/gui/widgets/image.hpp
    M src/gui/widgets/label.cpp
    M src/gui/widgets/label.hpp
    M src/gui/widgets/list.hpp
    M src/gui/widgets/listbox.cpp
    M src/gui/widgets/listbox.hpp
    M src/gui/widgets/matrix.hpp
    M src/gui/widgets/menu_button.cpp
    M src/gui/widgets/menu_button.hpp
    M src/gui/widgets/minimap.cpp
    M src/gui/widgets/minimap.hpp
    M src/gui/widgets/multi_page.cpp
    M src/gui/widgets/multi_page.hpp
    M src/gui/widgets/multimenu_button.cpp
    M src/gui/widgets/multimenu_button.hpp
    M src/gui/widgets/panel.cpp
    M src/gui/widgets/panel.hpp
    M src/gui/widgets/password_box.cpp
    M src/gui/widgets/password_box.hpp
    M src/gui/widgets/progress_bar.cpp
    M src/gui/widgets/progress_bar.hpp
    M src/gui/widgets/repeating_button.cpp
    M src/gui/widgets/repeating_button.hpp
    M src/gui/widgets/scroll_label.cpp
    M src/gui/widgets/scroll_label.hpp
    M src/gui/widgets/scrollbar_container.cpp
    M src/gui/widgets/scrollbar_container.hpp
    M src/gui/widgets/scrollbar_panel.cpp
    M src/gui/widgets/scrollbar_panel.hpp
    M src/gui/widgets/size_lock.cpp
    M src/gui/widgets/size_lock.hpp
    M src/gui/widgets/slider.cpp
    M src/gui/widgets/slider.hpp
    M src/gui/widgets/spacer.cpp
    M src/gui/widgets/spacer.hpp
    M src/gui/widgets/stacked_widget.cpp
    M src/gui/widgets/stacked_widget.hpp
    M src/gui/widgets/styled_widget.hpp
    M src/gui/widgets/text_box.cpp
    M src/gui/widgets/text_box.hpp
    M src/gui/widgets/toggle_button.cpp
    M src/gui/widgets/toggle_button.hpp
    M src/gui/widgets/toggle_panel.cpp
    M src/gui/widgets/toggle_panel.hpp
    M src/gui/widgets/tree_view.cpp
    M src/gui/widgets/tree_view.hpp
    M src/gui/widgets/unit_preview_pane.cpp
    M src/gui/widgets/unit_preview_pane.hpp
    M src/gui/widgets/vertical_scrollbar.cpp
    M src/gui/widgets/vertical_scrollbar.hpp
    M src/gui/widgets/window.cpp
    M src/gui/widgets/window.hpp

  Log Message:
  -----------
  GUI2: added a public static type getter to all widgets implementing get_control_type

Fixes #2400. See comment in styled_widget.hpp for details.


Compare: https://github.com/wesnoth/wesnoth/compare/189df969b5f7...90518b645ca0
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the Commits mailing list