[wesnoth-commits] [wesnoth/wesnoth] 8f1a53: AI/Game Info: formatting/forward declaration clean...

GitHub noreply at github.com
Mon Oct 8 19:25:45 UTC 2018


  Branch: refs/heads/1.14
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 8f1a535ef442c94029e76342c05f5abdf6a88767
      https://github.com/wesnoth/wesnoth/commit/8f1a535ef442c94029e76342c05f5abdf6a88767
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-10-07 (Sun, 07 Oct 2018)

  Changed paths:
    M src/ai/game_info.hpp

  Log Message:
  -----------
  AI/Game Info: formatting/forward declaration cleanup


  Commit: 171807e04bee506ba814c37cca37c8f382345f89
      https://github.com/wesnoth/wesnoth/commit/171807e04bee506ba814c37cca37c8f382345f89
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-10-07 (Sun, 07 Oct 2018)

  Changed paths:
    M src/ai/composite/aspect.hpp
    M src/ai/contexts.cpp
    M src/ai/contexts.hpp
    M src/ai/game_info.hpp

  Log Message:
  -----------
  AI: simplify some typedefs with template aliases


  Commit: f726a86ba558e3c2d6ba703c92ddf5e5e4739f3c
      https://github.com/wesnoth/wesnoth/commit/f726a86ba558e3c2d6ba703c92ddf5e5e4739f3c
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-10-07 (Sun, 07 Oct 2018)

  Changed paths:
    M projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj
    M source_lists/libwesnoth_widgets
    M src/gui/core/gui_definition.cpp
    M src/gui/dialogs/addon/manager.cpp
    M src/gui/dialogs/addon/uninstall_list.cpp
    M src/gui/dialogs/campaign_difficulty.cpp
    M src/gui/dialogs/campaign_selection.cpp
    M src/gui/dialogs/chat_log.cpp
    M src/gui/dialogs/core_selection.cpp
    M src/gui/dialogs/depcheck_select_new.cpp
    M src/gui/dialogs/editor/generate_map.cpp
    M src/gui/dialogs/editor/set_starting_position.cpp
    M src/gui/dialogs/file_dialog.cpp
    M src/gui/dialogs/game_load.cpp
    M src/gui/dialogs/game_stats.cpp
    M src/gui/dialogs/game_version_dialog.cpp
    M src/gui/dialogs/game_version_dialog.hpp
    M src/gui/dialogs/label_settings.cpp
    M src/gui/dialogs/language_selection.cpp
    M src/gui/dialogs/multiplayer/faction_select.cpp
    M src/gui/dialogs/multiplayer/lobby.cpp
    M src/gui/dialogs/multiplayer/lobby.hpp
    M src/gui/dialogs/multiplayer/mp_change_control.cpp
    M src/gui/dialogs/multiplayer/mp_connect.cpp
    M src/gui/dialogs/multiplayer/mp_create_game.cpp
    M src/gui/dialogs/multiplayer/mp_join_game.cpp
    M src/gui/dialogs/multiplayer/mp_method_selection.cpp
    M src/gui/dialogs/multiplayer/mp_staging.cpp
    M src/gui/dialogs/preferences_dialog.cpp
    M src/gui/dialogs/simple_item_selector.cpp
    M src/gui/dialogs/statistics_dialog.cpp
    M src/gui/dialogs/terrain_layers.cpp
    M src/gui/dialogs/theme_list.cpp
    M src/gui/dialogs/unit_advance.cpp
    M src/gui/dialogs/unit_attack.cpp
    M src/gui/dialogs/unit_create.cpp
    M src/gui/dialogs/unit_list.cpp
    M src/gui/dialogs/unit_recall.cpp
    M src/gui/dialogs/unit_recruit.cpp
    M src/gui/dialogs/wml_message.cpp
    M src/gui/widgets/debug.cpp
    R src/gui/widgets/list.cpp
    R src/gui/widgets/list.hpp
    M src/gui/widgets/listbox.cpp
    M src/gui/widgets/listbox.hpp
    M src/gui/widgets/scrollbar_container.hpp
    M src/scripting/lua_gui2.cpp

  Log Message:
  -----------
  GUI2: removed 2010 experimental listbox

This was never finished, is not maintained, suffers from a lack of features the "old" listbox
class now has, and seems (according to the logs) to be have been superceded by the pane widget.
At the very least, the pane widget seems to be what mordante was working with in his early
prototype of a new addon manager, and not this 2010 list class.

since this was removed in master, there is little point for keeping it in 1.14


  Commit: b42631e8594a556a3925d84e18cacb0d4d3d14c7
      https://github.com/wesnoth/wesnoth/commit/b42631e8594a556a3925d84e18cacb0d4d3d14c7
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-10-07 (Sun, 07 Oct 2018)

  Changed paths:
    M src/actions/advancement.cpp
    M src/editor/map/context_manager.cpp
    M src/hotkey/command_executor.cpp
    M src/menu_events.cpp
    M src/mouse_events.cpp
    M src/savegame.cpp

  Log Message:
  -----------
  Used the return value of modal_dialog::show instead of an explicit retval check when possible


  Commit: 56e6e7366c02c46f8ba3f862edaba5086026a6a5
      https://github.com/wesnoth/wesnoth/commit/56e6e7366c02c46f8ba3f862edaba5086026a6a5
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-10-07 (Sun, 07 Oct 2018)

  Changed paths:
    M src/controller_base.cpp
    M src/controller_base.hpp
    M src/editor/controller/editor_controller.cpp
    M src/editor/controller/editor_controller.hpp
    M src/editor/editor_main.cpp
    M src/editor/editor_main.hpp
    M src/game_initialization/lobby_data.cpp
    M src/game_initialization/lobby_data.hpp
    M src/game_initialization/lobby_info.cpp
    M src/game_initialization/lobby_info.hpp
    M src/game_initialization/multiplayer.cpp
    M src/game_initialization/multiplayer.hpp
    M src/game_initialization/playcampaign.cpp
    M src/game_initialization/playcampaign.hpp
    M src/game_launcher.cpp
    M src/menu_events.cpp
    M src/menu_events.hpp
    M src/play_controller.cpp
    M src/play_controller.hpp
    M src/playmp_controller.cpp
    M src/playmp_controller.hpp
    M src/playsingle_controller.cpp
    M src/playsingle_controller.hpp
    M src/tests/gui/test_gui2.cpp

  Log Message:
  -----------
  Stop passing a milion game_config refs around during game initializaton

There are only 3 places where it's actually really needed. Used the game_config_manager
singleton to retrieve a reference in those cases.


  Commit: cb43d8b35fb3e0b9d8d3dd0d802db294e0720c35
      https://github.com/wesnoth/wesnoth/commit/cb43d8b35fb3e0b9d8d3dd0d802db294e0720c35
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-10-07 (Sun, 07 Oct 2018)

  Changed paths:
    M src/actions/move.cpp
    M src/ai/simulated_actions.cpp
    M src/build_info.cpp
    M src/generators/default_map_generator_job.cpp
    M src/gui/dialogs/drop_down_menu.cpp
    M src/gui/dialogs/editor/generate_map.cpp
    M src/gui/dialogs/file_dialog.cpp
    M src/image_modifications.cpp
    M src/scripting/game_lua_kernel.cpp
    M src/scripting/lua_gui2.cpp
    M src/sdl/utils.cpp
    M src/soundsource.cpp
    M src/units/unit.cpp

  Log Message:
  -----------
  Convert a bunch more C-style casts I missed in 0dc5656 to static_cast


  Commit: b07afc2a974d6b08fd9f813f1e63a07fb2d78567
      https://github.com/wesnoth/wesnoth/commit/b07afc2a974d6b08fd9f813f1e63a07fb2d78567
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-10-07 (Sun, 07 Oct 2018)

  Changed paths:
    M src/build_info.cpp
    M src/config.cpp
    M src/tstring.cpp

  Log Message:
  -----------
  Convert a few remaining C-style casts (for char) too static_cast


  Commit: c7e14da5ec73025ac0d687e11c85ddd44cefb360
      https://github.com/wesnoth/wesnoth/commit/c7e14da5ec73025ac0d687e11c85ddd44cefb360
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-10-07 (Sun, 07 Oct 2018)

  Changed paths:
    M src/ai/composite/goal.cpp
    M src/ai/default/attack.cpp
    M src/ai/default/ca.cpp
    M src/ai/default/ca_move_to_targets.cpp
    M src/ai/default/contexts.cpp
    M src/ai/formula/function_table.cpp
    M src/ai/testing.cpp
    M src/attack_prediction.cpp
    M src/color.hpp
    M src/deprecation.cpp
    M src/display.cpp
    M src/display.hpp
    M src/editor/controller/editor_controller.cpp
    M src/formula/string_utils.cpp
    M src/game_events/action_wml.cpp
    M src/game_state.cpp
    M src/generators/cave_map_generator.cpp
    M src/generators/default_map_generator_job.cpp
    M src/gui/dialogs/file_dialog.cpp
    M src/gui/widgets/slider.cpp
    M src/hash.cpp
    M src/mouse_events.cpp
    M src/pathfind/astarsearch.cpp
    M src/play_controller.cpp
    M src/preferences/general.cpp
    M src/replay.cpp
    M src/replay_helper.cpp
    M src/reports.cpp
    M src/scripting/game_lua_kernel.cpp
    M src/scripting/lua_kernel_base.cpp
    M src/sdl/utils.cpp
    M src/serialization/string_utils.cpp
    M src/server/forum_user_handler.cpp
    M src/team.cpp
    M src/terrain/builder.cpp
    M src/units/abilities.cpp
    M src/units/drawer.cpp
    M src/units/unit.cpp
    M src/variable.cpp
    M src/whiteboard/manager.cpp

  Log Message:
  -----------
  Convert C-style casts to static_cast


  Commit: d21feda0326cb36a145d7136e7d148df8c578cda
      https://github.com/wesnoth/wesnoth/commit/d21feda0326cb36a145d7136e7d148df8c578cda
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-10-07 (Sun, 07 Oct 2018)

  Changed paths:
    M src/config.cpp

  Log Message:
  -----------
  Use '\t' instead of static_cast<char>(9)


Compare: https://github.com/wesnoth/wesnoth/compare/55bc62f442da...d21feda0326c
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the Commits mailing list