[wesnoth-commits] [wesnoth/wesnoth] 808bd5: don't call invalidate_layout() unless needed

[GitHub]

  Branch: refs/heads/1.14
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 808bd59dae43b57ff8f1fa39158af9722191872d
      https://github.com/wesnoth/wesnoth/commit/808bd59dae43b57ff8f1fa39158af9722191872d
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2018-10-11 (Thu, 11 Oct 2018)

  Changed paths:
    M src/scripting/lua_gui2.cpp

  Log Message:
  -----------
  don't call invalidate_layout() unless needed

commit 8000a868 added an invalidate layout() call to fix issues arisiong from widgets that change its site when their 'value' is changes.
But with this, some dialogs, in particular the custom help dialgog in the addon "world conquest 2", reacted much slower to user input because invalidate_layout() causes the dialogs to recaclulate all its siszes which is very slow. Since most of the widgets, in particular 'multi_page' don't change their size when the value is changed, this commit fixes the mentioned custom help dialog by not calling invalidate_layout() when cahnging the value of those widgets.



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.