[wesnoth-commits] [wesnoth/wesnoth] 1a7724: reset unit overlay & image_mods on advance_to

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 1a7724e547201d0ff1fda048b6079559d6da560c
      https://github.com/wesnoth/wesnoth/commit/1a7724e547201d0ff1fda048b6079559d6da560c
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2018-10-16 (Tue, 16 Oct 2018)

  Changed paths:
    M data/lua/wml-tags.lua
    M src/units/unit.cpp

  Log Message:
  -----------
  reset unit overlay & image_mods on advance_to

this fixes remove_modification for these effects, and also a bug where these effect would be applied twice after a unit advances.

fixes #3264
fixes #3220

This also changes the implementation of [unit_overlay] to use [effect]s now so tht changesdone via [unit_overlay] ae persistent as they were before.



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.