[wesnoth-commits] [wesnoth/wesnoth] 2bf39f: Fix #2884: minimap buttons don't do anything

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 2bf39f7ee884f7398843ab932f6c9562a8a6384b
      https://github.com/wesnoth/wesnoth/commit/2bf39f7ee884f7398843ab932f6c9562a8a6384b
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2018-10-17 (Wed, 17 Oct 2018)

  Changed paths:
    M src/hotkey/command_executor.cpp
    M src/hotkey/command_executor.hpp

  Log Message:
  -----------
  Fix #2884: minimap buttons don't do anything

Charry-pick of commit
a0b54b1513e840498e90572e0e4b9687df36a9cd.


  Commit: b3e1680f886ec27c29150912bb27949d7cdd7f6e
      https://github.com/wesnoth/wesnoth/commit/b3e1680f886ec27c29150912bb27949d7cdd7f6e
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2018-10-17 (Wed, 17 Oct 2018)

  Changed paths:
    M src/config.cpp
    M src/config.hpp
    M src/saved_game.cpp
    M src/saved_game.hpp

  Log Message:
  -----------
  Revert "put [resource] before other content; fixes #3345"

This reverts commit 706740220957a9313909f5cc358ba5aba3bf4118.

The commit used the `pos` iterator after invalidating
it (passing an iterator to `config::add_child_at()`
invalidates it), resulting in undefined behavior.


Compare: https://github.com/wesnoth/wesnoth/compare/f6933b98f8b5...b3e1680f886e
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.