[wesnoth-commits] [wesnoth/wesnoth] dccda8: allow wesnoth.simulate_combat to have defenders no...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: dccda8294b94555891b567a81d35da6439c34055
      https://github.com/wesnoth/wesnoth/commit/dccda8294b94555891b567a81d35da6439c34055
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2018-10-21 (Sun, 21 Oct 2018)

  Changed paths:
    M src/actions/attack.cpp
    M src/actions/attack.hpp
    M src/scripting/game_lua_kernel.cpp

  Log Message:
  -----------
  allow wesnoth.simulate_combat to have defenders not on the map.

just like it does for attackers.


  Commit: 262549433f11605bdb8354dc6e7cf9a17ad4004e
      https://github.com/wesnoth/wesnoth/commit/262549433f11605bdb8354dc6e7cf9a17ad4004e
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2018-10-21 (Sun, 21 Oct 2018)

  Changed paths:
    M src/scripting/game_lua_kernel.cpp
    M src/units/unit.hpp

  Log Message:
  -----------
  make wesnoth.simulate_combat a little more save against segfaults

it now keeps a unit_ptr to the unit to make sure the unit is not deleted
during whatever lua code the battle_context constructor calls. This can
be done because since the unit ctor refactor all unit objects are owned
by a unit_ptr (created by unit::create).

It might also be possible to refactor out the "unit * c_ptr" member of
lua_unit.


  Commit: 082aa2afe24815c1c432341e9fa9dd0d84da04a8
      https://github.com/wesnoth/wesnoth/commit/082aa2afe24815c1c432341e9fa9dd0d84da04a8
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2018-10-21 (Sun, 21 Oct 2018)

  Changed paths:
    M src/display.cpp
    M src/display.hpp
    M src/overlay.hpp
    M src/scripting/game_lua_kernel.cpp

  Log Message:
  -----------
  add z_order attribute to wesnoth.add_tile_overlay fixes #3156

this probably won't work for halos yet.


  Commit: 7d93ce1604a43f5875c43edd9da1cc766ec7310c
      https://github.com/wesnoth/wesnoth/commit/7d93ce1604a43f5875c43edd9da1cc766ec7310c
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2018-10-21 (Sun, 21 Oct 2018)

  Changed paths:
    M src/scripting/lua_common.cpp
    M src/scripting/lua_common.hpp
    M src/scripting/push_check.hpp

  Log Message:
  -----------
  add luaW_table_get_def


  Commit: 6bdbcc1644bf3dd04b0c8945ed5e3c1361ff82dc
      https://github.com/wesnoth/wesnoth/commit/6bdbcc1644bf3dd04b0c8945ed5e3c1361ff82dc
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2018-10-21 (Sun, 21 Oct 2018)

  Changed paths:
    M src/scripting/lua_unit.cpp
    M src/units/unit.hpp

  Log Message:
  -----------
  make max_moves a modifiable unit property


Compare: https://github.com/wesnoth/wesnoth/compare/d10c51feb1a6...6bdbcc1644bf
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.