[wesnoth-commits] [wesnoth/wesnoth] 165f2c: Accept ".." in file paths everywhere

[GitHub]

  Branch: refs/heads/rel_paths
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 165f2cd86eb24ba797d290877c4c9b8f18705345
      https://github.com/wesnoth/wesnoth/commit/165f2cd86eb24ba797d290877c4c9b8f18705345
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-10-23 (Tue, 23 Oct 2018)

  Changed paths:
    M src/filesystem.cpp
    M src/game_config_manager.cpp
    M src/scripting/lua_fileops.cpp
    M src/tests/test_filesystem.cpp

  Log Message:
  -----------
  Accept ".." in file paths everywhere

This accepts ".." without escaping the sandbox by first resolving it and
failing if the result begins in "..". Only then is the relative path
resolved to an absolute path.


  Commit: 31465c4716e3df20c2a97e85b81b179764042266
      https://github.com/wesnoth/wesnoth/commit/31465c4716e3df20c2a97e85b81b179764042266
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-10-23 (Tue, 23 Oct 2018)

  Changed paths:
    M src/filesystem.cpp

  Log Message:
  -----------
  Safety net (suggested by @gfgtdf)


  Commit: 0a3b24099deb6ca6d1781c905f7d79d49fedf275
      https://github.com/wesnoth/wesnoth/commit/0a3b24099deb6ca6d1781c905f7d79d49fedf275
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-10-23 (Tue, 23 Oct 2018)

  Changed paths:
    M src/tests/test_filesystem.cpp

  Log Message:
  -----------
  fixup tests


  Commit: 6fd03fe0f62154873d4fdef636f03b9f07de840c
      https://github.com/wesnoth/wesnoth/commit/6fd03fe0f62154873d4fdef636f03b9f07de840c
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-10-23 (Tue, 23 Oct 2018)

  Changed paths:
    M src/filesystem.cpp

  Log Message:
  -----------
  Another safety check (thanks @gfgtdf for spotting this)


  Commit: a3dea93308246198e751d5bfd467d1928f5d87b0
      https://github.com/wesnoth/wesnoth/commit/a3dea93308246198e751d5bfd467d1928f5d87b0
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-10-23 (Tue, 23 Oct 2018)

  Changed paths:
    M src/filesystem.cpp

  Log Message:
  -----------
  Previous fix broke something else


  Commit: a1b5890b5d453bbca5dae92b5017d4d2085b0c54
      https://github.com/wesnoth/wesnoth/commit/a1b5890b5d453bbca5dae92b5017d4d2085b0c54
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-10-23 (Tue, 23 Oct 2018)

  Changed paths:
    M src/filesystem.cpp
    M src/serialization/preprocessor.cpp

  Log Message:
  -----------
  Instead of trying to trap absolute paths in get_wml_location,
make the preprocessor not pass them.


Compare: https://github.com/wesnoth/wesnoth/compare/a7c494445e4d...a1b5890b5d45
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.