[wesnoth-commits] [wesnoth/wesnoth] 40214d: Help Browser: Actually show the correct topics wit...
GitHub
noreply at github.com
Wed Oct 24 02:52:49 UTC 2018
Branch: refs/heads/gui2_help
Home: https://github.com/wesnoth/wesnoth
Commit: 40214da0a1b2bc59f91187da9d8bf110fb866aae
https://github.com/wesnoth/wesnoth/commit/40214da0a1b2bc59f91187da9d8bf110fb866aae
Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
Date: 2018-10-23 (Tue, 23 Oct 2018)
Changed paths:
M data/gui/window/help_browser.cfg
M src/gui/dialogs/help_browser.cpp
M src/gui/dialogs/help_browser.hpp
M src/gui/dialogs/title_screen.cpp
Log Message:
-----------
Help Browser: Actually show the correct topics with the correct icons
This also fixes the lag when opening help and makes the topic text appear.
(The topic text is not parsed at the moment, though.)
Commit: b12ffe752bd0b4689d21f207ec328879daaa4d14
https://github.com/wesnoth/wesnoth/commit/b12ffe752bd0b4689d21f207ec328879daaa4d14
Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
Date: 2018-10-23 (Tue, 23 Oct 2018)
Changed paths:
M src/gui/dialogs/help_browser.cpp
M src/gui/dialogs/help_browser.hpp
M src/help/help.cpp
M src/help/help.hpp
Log Message:
-----------
Help Viewer: Show topics with generated text
Commit: 820687baf370dbe5a5f464f82012fd1b6f3ae7e6
https://github.com/wesnoth/wesnoth/commit/820687baf370dbe5a5f464f82012fd1b6f3ae7e6
Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
Date: 2018-10-23 (Tue, 23 Oct 2018)
Changed paths:
M src/help/help_impl.cpp
M src/help/help_impl.hpp
Log Message:
-----------
Help: That parameter isn't really needed
Commit: 02b472b05c38b76831f39989cafd92884c180a5e
https://github.com/wesnoth/wesnoth/commit/02b472b05c38b76831f39989cafd92884c180a5e
Author: Charles Dang <exodia339 at gmail.com>
Date: 2018-10-23 (Tue, 23 Oct 2018)
Changed paths:
M data/gui/window/help_browser.cfg
Log Message:
-----------
Help Browser: improved layout stability and added next/back buttons (non-functional, of course)
Commit: 3ddd5670d94b6049c47e0b1e56c331d70471807e
https://github.com/wesnoth/wesnoth/commit/3ddd5670d94b6049c47e0b1e56c331d70471807e
Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
Date: 2018-10-23 (Tue, 23 Oct 2018)
Changed paths:
M src/gui/dialogs/help_browser.cpp
M src/help/help_impl.cpp
M src/help/help_impl.hpp
M src/help/help_text_area.cpp
M src/help/help_text_area.hpp
Log Message:
-----------
Help Viewer: Parse help markup to Pango markup... mostly.
The help parser now outputs a config rather than a vector of strings of
which some should be taken literally and others parsed as WML.
Commit: 0630ca6d9ae69fe4f8e0a2d842726e6b0536e15e
https://github.com/wesnoth/wesnoth/commit/0630ca6d9ae69fe4f8e0a2d842726e6b0536e15e
Author: Charles Dang <exodia339 at gmail.com>
Date: 2018-10-23 (Tue, 23 Oct 2018)
Changed paths:
M data/gui/window/help_browser.cfg
M src/gui/dialogs/help_browser.cpp
M src/gui/dialogs/help_browser.hpp
Log Message:
-----------
Help Browser: implemented viewing of sub-sections/topics
Commit: ec5cdb4fe4d4c89e7c347ccf014a617c9e341b64
https://github.com/wesnoth/wesnoth/commit/ec5cdb4fe4d4c89e7c347ccf014a617c9e341b64
Author: Charles Dang <exodia339 at gmail.com>
Date: 2018-10-23 (Tue, 23 Oct 2018)
Changed paths:
M src/gui/dialogs/title_screen.cpp
M src/help/help.cpp
Log Message:
-----------
Moved new help entry point to a common location
Commit: f421a74864768e2848650dd099833e993b8f59c2
https://github.com/wesnoth/wesnoth/commit/f421a74864768e2848650dd099833e993b8f59c2
Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
Date: 2018-10-23 (Tue, 23 Oct 2018)
Changed paths:
M src/gui/dialogs/help_browser.cpp
M src/gui/dialogs/help_browser.hpp
Log Message:
-----------
Help Browser: Implement history
Commit: 8ac0ba61b494fce8bd44224521fe6162dba88999
https://github.com/wesnoth/wesnoth/commit/8ac0ba61b494fce8bd44224521fe6162dba88999
Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
Date: 2018-10-23 (Tue, 23 Oct 2018)
Changed paths:
M src/help/help_text_area.cpp
Log Message:
-----------
Fix GUI1 help topics not showing
Commit: 8dbd895b21ad8fc5df1c7318fe4564c74330ecf7
https://github.com/wesnoth/wesnoth/commit/8dbd895b21ad8fc5df1c7318fe4564c74330ecf7
Author: Charles Dang <exodia339 at gmail.com>
Date: 2018-10-23 (Tue, 23 Oct 2018)
Changed paths:
A data/gui/widget/toggle_button_help_topic.cfg
M data/gui/window/help_browser.cfg
M src/gui/dialogs/help_browser.cpp
Log Message:
-----------
Help Browser: properly implement toggling by clicking the book icons
Commit: 67e42359181b0d05afaf8a9f7c781482408b8317
https://github.com/wesnoth/wesnoth/commit/67e42359181b0d05afaf8a9f7c781482408b8317
Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
Date: 2018-10-23 (Tue, 23 Oct 2018)
Changed paths:
M src/gui/dialogs/help_browser.cpp
Log Message:
-----------
Help Browser: Fix back button being visible when dialog opens
Commit: 9fa470ddfcd0f965da5f3fa7ce406797fad4e88e
https://github.com/wesnoth/wesnoth/commit/9fa470ddfcd0f965da5f3fa7ce406797fad4e88e
Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
Date: 2018-10-23 (Tue, 23 Oct 2018)
Changed paths:
M data/gui/window/help_browser.cfg
M src/gui/dialogs/help_browser.cpp
Log Message:
-----------
Help Browser: Show topic title
Commit: 25ab7f04f77b9f1fdf6425e0d059a76ab0ae20b6
https://github.com/wesnoth/wesnoth/commit/25ab7f04f77b9f1fdf6425e0d059a76ab0ae20b6
Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
Date: 2018-10-23 (Tue, 23 Oct 2018)
Changed paths:
M src/gui/dialogs/help_browser.cpp
Log Message:
-----------
Help Browser: Don't double-list a section's root topic
Commit: c2e100a937976a35df9caf60f33498c6292ff46e
https://github.com/wesnoth/wesnoth/commit/c2e100a937976a35df9caf60f33498c6292ff46e
Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
Date: 2018-10-23 (Tue, 23 Oct 2018)
Changed paths:
M src/gui/dialogs/help_browser.cpp
M src/gui/dialogs/help_browser.hpp
M src/help/help.cpp
Log Message:
-----------
Help Browser: Support arbitrary initial topic
Hidden topics still untested.
Commit: 1fc9500af15e6807d62a89b03fa54177ea2bd71a
https://github.com/wesnoth/wesnoth/commit/1fc9500af15e6807d62a89b03fa54177ea2bd71a
Author: Charles Dang <exodia339 at gmail.com>
Date: 2018-10-23 (Tue, 23 Oct 2018)
Changed paths:
M data/gui/window/help_browser.cfg
Log Message:
-----------
Help Browser: fixup topic title layout
Commit: 5b99f3ae830d107dbf1ba9dbbdc3c8d10271e6a1
https://github.com/wesnoth/wesnoth/commit/5b99f3ae830d107dbf1ba9dbbdc3c8d10271e6a1
Author: Charles Dang <exodia339 at gmail.com>
Date: 2018-10-23 (Tue, 23 Oct 2018)
Changed paths:
M data/gui/window/help_browser.cfg
Log Message:
-----------
Help Browser: removed help topic padding
Commit: bfe5f4a2ec6af4d1c7ea8df48b1859effd6d4528
https://github.com/wesnoth/wesnoth/commit/bfe5f4a2ec6af4d1c7ea8df48b1859effd6d4528
Author: Charles Dang <exodia339 at gmail.com>
Date: 2018-10-23 (Tue, 23 Oct 2018)
Changed paths:
M data/gui/widget/toggle_button_help_topic.cfg
M src/gui/dialogs/help_browser.cpp
M src/help/help_impl.cpp
Log Message:
-----------
Some build fixups to reflect changes since the help commits were originally made
Commit: a4beeee3906da8a0086886cd9b94aaff99ad7734
https://github.com/wesnoth/wesnoth/commit/a4beeee3906da8a0086886cd9b94aaff99ad7734
Author: Charles Dang <exodia339 at gmail.com>
Date: 2018-10-23 (Tue, 23 Oct 2018)
Changed paths:
M src/help/help.cpp
M src/help/help.hpp
Log Message:
-----------
Help: removed code to show old GUI1 help browser
Attempting to launch it crashes the game (probably to do with a null video surface),
and since it's being replaced there's no point in restoring it to functionality.
The implementation details (help_menu, etc) have been left for now. Will remove soon.
This also means the GUI2 help browser is shown by default now.
Commit: e8d23ccf336760800fbcd97f45a3ce69bf6a54ce
https://github.com/wesnoth/wesnoth/commit/e8d23ccf336760800fbcd97f45a3ce69bf6a54ce
Author: Charles Dang <exodia339 at gmail.com>
Date: 2018-10-23 (Tue, 23 Oct 2018)
Changed paths:
M source_lists/wesnoth
M src/help/help.cpp
R src/help/help_browser.cpp
R src/help/help_browser.hpp
R src/help/help_menu.cpp
R src/help/help_menu.hpp
R src/help/help_text_area.cpp
R src/help/help_text_area.hpp
Log Message:
-----------
Removed GUI1 Help interface code
Not needed anymore since we're moving to GUI2 for this dialog.
Commit: 88d8b9c933572bf9f661e074aae1217593099c3a
https://github.com/wesnoth/wesnoth/commit/88d8b9c933572bf9f661e074aae1217593099c3a
Author: Charles Dang <exodia339 at gmail.com>
Date: 2018-10-23 (Tue, 23 Oct 2018)
Changed paths:
M source_lists/libwesnoth
M source_lists/wesnoth
M src/controller_base.cpp
M src/display.cpp
R src/floating_textbox.cpp
R src/floating_textbox.hpp
M src/help/help.cpp
M src/hotkey/command_executor.cpp
R src/show_dialog.cpp
R src/show_dialog.hpp
R src/widgets/button.cpp
R src/widgets/button.hpp
R src/widgets/menu.cpp
R src/widgets/menu.hpp
R src/widgets/menu_style.cpp
R src/widgets/scrollarea.cpp
R src/widgets/scrollarea.hpp
R src/widgets/scrollbar.cpp
R src/widgets/scrollbar.hpp
R src/widgets/textbox.cpp
R src/widgets/textbox.hpp
R src/widgets/widget.cpp
R src/widgets/widget.hpp
Log Message:
-----------
Removed a whole bunch of GUI1 stuff
This almost completely removes GUI1, save for the button widget (will remove once I get
all the Theme handling sorted out) and the editor's own GUI1 widgets.
This includes the GUI1 textbox, scrollbar, scrollarea, and menu widgets, as well as the
dialog_frame and dialog_manager classes. I've also removed floating_textbox. It was only
kept around for reference (it's unused as of the inclusion of the GUI2 command console).
gui::in_dialog has been replaced by GUI2's is_in_dialog directly now that we have no more
GUI1 dialogs.
\o/
Commit: e82471a972158f2430d395854f840981b1f206f4
https://github.com/wesnoth/wesnoth/commit/e82471a972158f2430d395854f840981b1f206f4
Author: Charles Dang <exodia339 at gmail.com>
Date: 2018-10-23 (Tue, 23 Oct 2018)
Changed paths:
M src/help/help.cpp
M src/help/help.hpp
Log Message:
-----------
Help: formatting/doc/include cleanup
Commit: 4ba895f0fcdf7e80151ef9f99567d36206d1aca1
https://github.com/wesnoth/wesnoth/commit/4ba895f0fcdf7e80151ef9f99567d36206d1aca1
Author: Charles Dang <exodia339 at gmail.com>
Date: 2018-10-23 (Tue, 23 Oct 2018)
Changed paths:
M data/core/editor/help.cfg
M data/core/help.cfg
Log Message:
-----------
Help: replaced custom <bold> and <italic> formatting tags with Pango equivalents
[ci skip]
Commit: 06fb491e1e3472e1016374d9693b826ba5999666
https://github.com/wesnoth/wesnoth/commit/06fb491e1e3472e1016374d9693b826ba5999666
Author: Charles Dang <exodia339 at gmail.com>
Date: 2018-10-23 (Tue, 23 Oct 2018)
Changed paths:
M data/core/editor/help.cfg
M data/core/help.cfg
Log Message:
-----------
Help: replaced custom <header> formatting tag with <big>
[ci skip]
Commit: 36571cad61e1689940786d74d2ef04a6bd2ccbb1
https://github.com/wesnoth/wesnoth/commit/36571cad61e1689940786d74d2ef04a6bd2ccbb1
Author: Charles Dang <exodia339 at gmail.com>
Date: 2018-10-23 (Tue, 23 Oct 2018)
Changed paths:
M src/gui/dialogs/help_browser.cpp
Log Message:
-----------
Help Browser: removed custom formatting conversion for <bold>, <italic>, and <header>
Commit: d7dc0cbdf6a4ddfd5055a92c312c2bf09a8338cb
https://github.com/wesnoth/wesnoth/commit/d7dc0cbdf6a4ddfd5055a92c312c2bf09a8338cb
Author: Charles Dang <exodia339 at gmail.com>
Date: 2018-10-23 (Tue, 23 Oct 2018)
Changed paths:
M src/editor/controller/editor_controller.cpp
M src/editor/controller/editor_controller.hpp
M src/gui/dialogs/title_screen.cpp
M src/help/help.cpp
M src/help/help.hpp
M src/play_controller.cpp
M src/play_controller.hpp
Log Message:
-----------
Removed help_manager struct (it will be replaced)
This is in preparation for a larger refactor.
Commit: 39d823ccde3caa8c4ac4a34d91998e02082fb63b
https://github.com/wesnoth/wesnoth/commit/39d823ccde3caa8c4ac4a34d91998e02082fb63b
Author: Charles Dang <exodia339 at gmail.com>
Date: 2018-10-23 (Tue, 23 Oct 2018)
Changed paths:
M src/editor/map/map_context.cpp
M src/pathfind/teleport.cpp
M src/statistics.cpp
Log Message:
-----------
Use proper bool instead of yes/no when setting config values
Commit: 669c80c255caa20606fd23964505aa55b886f2fe
https://github.com/wesnoth/wesnoth/commit/669c80c255caa20606fd23964505aa55b886f2fe
Author: Charles Dang <exodia339 at gmail.com>
Date: 2018-10-23 (Tue, 23 Oct 2018)
Changed paths:
M data/core/terrain.cfg
Log Message:
-----------
Terrains: convert italic help formatting to Pango markup
[ci skip]
Commit: be8340db2ece0357ef287f2c7956b9cbd6028141
https://github.com/wesnoth/wesnoth/commit/be8340db2ece0357ef287f2c7956b9cbd6028141
Author: Charles Dang <exodia339 at gmail.com>
Date: 2018-10-23 (Tue, 23 Oct 2018)
Changed paths:
M data/core/help.cfg
Log Message:
-----------
Help: explicitly sort Terrain sections
[ci skip]
This happened incidentally with the current help implementation, but that no longer happens
with my in-progress refactor. We still want these sections sorted, though.
The removal of the "sort_sections=generated" key from the Eras section is a forward-port of
6b20ccdb6282084b1fdb446d8a93d621204e8408 from 1.14.
Commit: 23026434ffec2116c32af75fd9a8a20c9a91d257
https://github.com/wesnoth/wesnoth/commit/23026434ffec2116c32af75fd9a8a20c9a91d257
Author: Charles Dang <exodia339 at gmail.com>
Date: 2018-10-23 (Tue, 23 Oct 2018)
Changed paths:
M data/core/help.cfg
Log Message:
-----------
I missed a case of <header>
[ci skip]
Commit: b2f6b174d475531ead6014ca42318d18e34b8725
https://github.com/wesnoth/wesnoth/commit/b2f6b174d475531ead6014ca42318d18e34b8725
Author: Charles Dang <exodia339 at gmail.com>
Date: 2018-10-23 (Tue, 23 Oct 2018)
Changed paths:
M data/multiplayer/factions/drakes-aoh.cfg
M data/multiplayer/factions/drakes-default.cfg
M data/multiplayer/factions/dunefolk-aoh.cfg
M data/multiplayer/factions/dunefolk-default.cfg
M data/multiplayer/factions/knalgans-aoh.cfg
M data/multiplayer/factions/knalgans-default.cfg
M data/multiplayer/factions/loyalists-aoh.cfg
M data/multiplayer/factions/loyalists-default.cfg
M data/multiplayer/factions/northerners-aoh.cfg
M data/multiplayer/factions/northerners-default.cfg
M data/multiplayer/factions/rebels-aoh.cfg
M data/multiplayer/factions/rebels-default.cfg
M data/multiplayer/factions/undead-aoh.cfg
M data/multiplayer/factions/undead-default.cfg
Log Message:
-----------
MP Factions: converted bold help markup to Pango markup
[ci skip]
Commit: 0dc8869110dd6bc76ab036414e099926dc4fa5d5
https://github.com/wesnoth/wesnoth/commit/0dc8869110dd6bc76ab036414e099926dc4fa5d5
Author: Charles Dang <exodia339 at gmail.com>
Date: 2018-10-23 (Tue, 23 Oct 2018)
Changed paths:
M data/core/units.cfg
Log Message:
-----------
Units: convert header and italic help markup to Pango markup
[ci skip]
Commit: 81388ad250ecfc9a8bb5f406f019843265bb4416
https://github.com/wesnoth/wesnoth/commit/81388ad250ecfc9a8bb5f406f019843265bb4416
Author: Charles Dang <exodia339 at gmail.com>
Date: 2018-10-23 (Tue, 23 Oct 2018)
Changed paths:
M data/gui/window/help_browser.cfg
M source_lists/wesnoth
M src/editor/controller/editor_controller.cpp
M src/gui/dialogs/help_browser.cpp
M src/gui/dialogs/help_browser.hpp
M src/gui/widgets/unit_preview_pane.cpp
A src/help/constants.cpp
A src/help/constants.hpp
M src/help/help.cpp
M src/help/help.hpp
R src/help/help_topic_generators.cpp
A src/help/manager.cpp
A src/help/manager.hpp
A src/help/section.cpp
A src/help/section.hpp
A src/help/section_generators.cpp
A src/help/section_generators.hpp
A src/help/topic.cpp
A src/help/topic.hpp
A src/help/topic_generators.cpp
A src/help/topic_generators.hpp
A src/help/topic_text_generators.cpp
A src/help/topic_text_generators.hpp
A src/help/utils.cpp
A src/help/utils.hpp
M src/play_controller.cpp
Log Message:
-----------
Help: massive refactor and cleanup of the help backend
This basically splits all the stuff in help/help_impl.*pp into multiple files by their
function, and refactors the entire workflow into a proper object-oriented interface in
modern C++.
There are still a features missing (such as hidden section parsing in the manager) that
I'll get back to.
Few incidental changes and fixes:
* Terrain topics now sorted alphabetically.
* Help text now small
* Fixed wrong toggle button id in browser. This is what was making it impossible to expand
any sections.
The GUI2 help browser is now back in working order, inasmuch as you can view all sections'
and topics' text (save units').
Commit: b81b5ba66ee0fd9c4b8c4c52553c85d1a22825c9
https://github.com/wesnoth/wesnoth/commit/b81b5ba66ee0fd9c4b8c4c52553c85d1a22825c9
Author: Charles Dang <exodia339 at gmail.com>
Date: 2018-10-23 (Tue, 23 Oct 2018)
Changed paths:
R src/help/help_impl.cpp
R src/help/help_impl.hpp
R src/help/help_topic_generators.hpp
Log Message:
-----------
How did these sneak past... (fixup 23e78ab)
Commit: 0e21a6425b144fabf263f19526f2facc7e04345c
https://github.com/wesnoth/wesnoth/commit/0e21a6425b144fabf263f19526f2facc7e04345c
Author: Charles Dang <exodia339 at gmail.com>
Date: 2018-10-23 (Tue, 23 Oct 2018)
Changed paths:
M src/help/manager.cpp
M src/help/manager.hpp
Log Message:
-----------
Help/Manager: don't need to keep a game config pointer anymore
I had removed the code that used it. We can just keep a help config pointer.
Commit: 92f786f7e07386805b256bcddcc1d3490d27c77d
https://github.com/wesnoth/wesnoth/commit/92f786f7e07386805b256bcddcc1d3490d27c77d
Author: Charles Dang <exodia339 at gmail.com>
Date: 2018-10-23 (Tue, 23 Oct 2018)
Changed paths:
M src/help/section.hpp
Log Message:
-----------
Fix extra qualifier on function declaration
Commit: 116edad6f410322ac17a4890f475fd5785788261
https://github.com/wesnoth/wesnoth/commit/116edad6f410322ac17a4890f475fd5785788261
Author: Charles Dang <exodia339 at gmail.com>
Date: 2018-10-23 (Tue, 23 Oct 2018)
Changed paths:
M src/help/topic_text_generators.cpp
Log Message:
-----------
Help: removed useless 'is nonnull' debug info from terrain topics
is_nonnull() just means "is not "none" or void terrain".
Commit: 5d69e6c03ce5c6ca2af9cd6b6d17dacc38914010
https://github.com/wesnoth/wesnoth/commit/5d69e6c03ce5c6ca2af9cd6b6d17dacc38914010
Author: Charles Dang <exodia339 at gmail.com>
Date: 2018-10-23 (Tue, 23 Oct 2018)
Changed paths:
M src/help/topic_generators.cpp
Log Message:
-----------
Help: fixed ambiguous overload, config copying
Commit: 86debf7c2180a30858dc25151fb28d5e8c25cc7b
https://github.com/wesnoth/wesnoth/commit/86debf7c2180a30858dc25151fb28d5e8c25cc7b
Author: Charles Dang <exodia339 at gmail.com>
Date: 2018-10-23 (Tue, 23 Oct 2018)
Changed paths:
M src/help/topic_generators.cpp
Log Message:
-----------
Fixup 3865a16
Commit: 50e27afc479ee6d63a0ccb15aa3cddaeb89d9a48
https://github.com/wesnoth/wesnoth/commit/50e27afc479ee6d63a0ccb15aa3cddaeb89d9a48
Author: Charles Dang <exodia339 at gmail.com>
Date: 2018-10-23 (Tue, 23 Oct 2018)
Changed paths:
M src/help/topic_text_generators.hpp
Log Message:
-----------
Help: mark currently unused-parameter as such for now
Commit: a638e8cc33404bbc757ab08886f436201e78a7d3
https://github.com/wesnoth/wesnoth/commit/a638e8cc33404bbc757ab08886f436201e78a7d3
Author: Charles Dang <exodia339 at gmail.com>
Date: 2018-10-23 (Tue, 23 Oct 2018)
Changed paths:
M src/display.cpp
Log Message:
-----------
Fixed crash when starting the editor (fixes #2816)
If no display_context was passed to the display ctor (such as is the case in the editor),
the terrain_builder's gamemap pointer would be null. Really not sure why this didn't cause
a crash n the 1.14 branch, but oh well.
I just removed the ctor call to rebuild_all() since it's not really needed. The map is
rebuilt when change_display_context is called anyway, which both the editor_controller and
play_controller do.
Commit: 0a394732a00ec58ad983d82e7a9ebde2aad8a318
https://github.com/wesnoth/wesnoth/commit/0a394732a00ec58ad983d82e7a9ebde2aad8a318
Author: Charles Dang <exodia339 at gmail.com>
Date: 2018-10-23 (Tue, 23 Oct 2018)
Changed paths:
M src/help/topic_generators.cpp
M src/help/utils.cpp
M src/help/utils.hpp
Log Message:
-----------
Help: moved a util function to the only file in which it is used
Commit: ffbc768de53a732aa74b7185f5c5707355ac5f15
https://github.com/wesnoth/wesnoth/commit/ffbc768de53a732aa74b7185f5c5707355ac5f15
Author: Charles Dang <exodia339 at gmail.com>
Date: 2018-10-23 (Tue, 23 Oct 2018)
Changed paths:
M src/help/manager.cpp
Log Message:
-----------
Help/Manager: dead code begone!
Commit: c68968a900124705b93b6bf981f340df1ee90a40
https://github.com/wesnoth/wesnoth/commit/c68968a900124705b93b6bf981f340df1ee90a40
Author: Charles Dang <exodia339 at gmail.com>
Date: 2018-10-23 (Tue, 23 Oct 2018)
Changed paths:
M src/actions/heal.cpp
Log Message:
-----------
Fixup 7f60fb0 (missing include)
Commit: 29ffc91bdc25baa2e08a6f311404fb8bfefaf789
https://github.com/wesnoth/wesnoth/commit/29ffc91bdc25baa2e08a6f311404fb8bfefaf789
Author: Charles Dang <exodia339 at gmail.com>
Date: 2018-10-23 (Tue, 23 Oct 2018)
Changed paths:
M src/help/section.cpp
Log Message:
-----------
Help: fixed unit section such as the Walking Corpse's not generating
I didn't realize that is_valid_id was only meant to check IDs provided in the help config and
not IDs generated dynamically; the latter are always correct. Granted, the old code did actually
call its analogous codepath for race and era generation, but it did not for unit sections. My
refactor made it so this check happened *any* time a section was created, regardless of its source.
To rectify that, I moved ID validation for sections into the static section generation loop like
for topics. I also moved the topic id validation prior to the ToD generation, tweaked the invalid
id message, and renamed a variable for clarity and consistency.
Commit: 713cbca0ad382dab8e6a847c43825215ba03f1df
https://github.com/wesnoth/wesnoth/commit/713cbca0ad382dab8e6a847c43825215ba03f1df
Author: Charles Dang <exodia339 at gmail.com>
Date: 2018-10-23 (Tue, 23 Oct 2018)
Changed paths:
M src/gui/dialogs/help_browser.cpp
Log Message:
-----------
Help Browser: don't generate nodes for hidden topics, updated link color
See 1903b05 for GUI2 label link color change. Really, this shouldn't be hardcoded here,
but I'll get to that.
Compare: https://github.com/wesnoth/wesnoth/compare/bd00adffd48f...713cbca0ad38
**NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/
Functionality will be removed from GitHub.com on January 31st, 2019.
More information about the Commits
mailing list