[wesnoth-commits] [wesnoth/wesnoth] 0a8ab1: Fix #3650: rare crash in attack prediction

[GitHub]

  Branch: refs/heads/1.14
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 0a8ab11aa76c731ecb931e622661f91c4d730d80
      https://github.com/wesnoth/wesnoth/commit/0a8ab11aa76c731ecb931e622661f91c4d730d80
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2018-10-24 (Wed, 24 Oct 2018)

  Changed paths:
    M src/attack_prediction.cpp

  Log Message:
  -----------
  Fix #3650: rare crash in attack prediction

The calculation for the probability to be slowed was incorrect if both
units had slow and neither of them was slowed. Calculating the sum of all
probabilities in the "not hit" row/column is a valid approach: however,
if the unit itself can slow and the other unit isn't already slowed, then
some of the "not hit" cases end up into a different plane.

Probabilities from that plane are now counted as well.


  Commit: 9a8d4311c82fb32fed902e9eed73c8eb6cd85b20
      https://github.com/wesnoth/wesnoth/commit/9a8d4311c82fb32fed902e9eed73c8eb6cd85b20
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2018-10-24 (Wed, 24 Oct 2018)

  Changed paths:
    M changelog.md

  Log Message:
  -----------
  Changelog entry for commit 0a8ab11aa76


Compare: https://github.com/wesnoth/wesnoth/compare/4450da2b807a...9a8d4311c82f
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.