[wesnoth-commits] [wesnoth/wesnoth] 26629d: gui2/unit_create: Fix segfault on empty list when ...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 26629d4a621b74e90513842db577d5bd03a415de
      https://github.com/wesnoth/wesnoth/commit/26629d4a621b74e90513842db577d5bd03a415de
  Author: Iris Morelle <shadowm at wesnoth.org>
  Date:   2018-09-01 (Sat, 01 Sep 2018)

  Changed paths:
    M changelog.md
    M src/gui/dialogs/unit_create.cpp

  Log Message:
  -----------
  gui2/unit_create: Fix segfault on empty list when updating unit preview

This happens when the list comes up empty because of a non-matching
filter, e.g. "Elvish Archer222" and the user clicks on one of the gender
options in this state.

Ideally we should clear the preview pane and disable the options and OK
button here, but the former appears impossible and for some reason
changing the pane's visibility in filter_text_changed() doesn't work
reliably.


  Commit: b7c7fca8b10003d7d6445710a51ed0f740e9425c
      https://github.com/wesnoth/wesnoth/commit/b7c7fca8b10003d7d6445710a51ed0f740e9425c
  Author: Iris Morelle <shadowm at wesnoth.org>
  Date:   2018-09-01 (Sat, 01 Sep 2018)

  Changed paths:
    M changelog.md
    M src/gui/dialogs/unit_create.cpp

  Log Message:
  -----------
  gui2/unit_create: Allow searching by race name as well


Compare: https://github.com/wesnoth/wesnoth/compare/bcb6153b89ed...b7c7fca8b100
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.