[wesnoth-commits] [wesnoth/wesnoth] 7d6e2b: Lua API: implicitly clear animator after playing i...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 7d6e2b2a10a61e1704c38ea7ee6aa34178a29b38
      https://github.com/wesnoth/wesnoth/commit/7d6e2b2a10a61e1704c38ea7ee6aa34178a29b38
  Author: newfrenchy83 <31768074+newfrenchy83 at users.noreply.github.com>
  Date:   2018-09-09 (Sun, 09 Sep 2018)

  Changed paths:
    M data/lua/wml/animate_unit.lua
    M data/lua/wml/heal_unit.lua
    M data/lua/wml/kill.lua
    M src/scripting/game_lua_kernel.cpp

  Log Message:
  -----------
  Lua API: implicitly clear animator after playing it (#3536)

This prevents the animator from holding a strong reference to the target unit, which was keeping the unit object alive and thus preventing the unit halo, if any, from disappearing.



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.