[wesnoth-commits] [wesnoth/wesnoth] b67579: ai unit advancement improvements

[gfgtdf]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: b67579a030e371d717341c8b0214a742cdd21c0d
      https://github.com/wesnoth/wesnoth/commit/b67579a030e371d717341c8b0214a742cdd21c0d
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2019-12-02 (Mon, 02 Dec 2019)

  Changed paths:
    M src/actions/advancement.cpp
    M src/ai/manager.cpp
    M src/ai/manager.hpp

  Log Message:
  -----------
  ai unit advancement improvements

1) use ai unit advancement asepect also
   during [event]s fixes #4605

previously advancements of ai units
invoked by [event]s for example by
unstoring a unit with enough xp would
always do a purely random advancement even if
it happend during the ais own turn. Now the
advancemt_aspect is considered. I don't really
know how the code inside ai/ works so i just
took the easiert way to get a advancements_aspect
from the manager. In particular this leaves a
TODO comment about whether the advancemnts_aspect
of advance_unit_at (and thus of
attack_and_advance) can not be removed or not
because i don't know whether the advancement
aspect is effectively a singleton (per side)
or not.

2) support amlas in ai units_advancement_aspect


  Commit: 7ddf61f08a37a7add18491ff7d46c7235c0b7372
      https://github.com/wesnoth/wesnoth/commit/7ddf61f08a37a7add18491ff7d46c7235c0b7372
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2019-12-02 (Mon, 02 Dec 2019)

  Changed paths:
    M src/actions/advancement.cpp

  Log Message:
  -----------
  don't abort advancement on invalid advancement index

this would in theory give the player
the option to postpone a unit
advancement by selecting an invalid
advancement index. Now we just use the
first advancement in case of an invalid
advancement index.


  Commit: f40a51c3ef1e0c885f8898b002c09433f6ad4721
      https://github.com/wesnoth/wesnoth/commit/f40a51c3ef1e0c885f8898b002c09433f6ad4721
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2019-12-02 (Mon, 02 Dec 2019)

  Changed paths:
    M src/actions/advancement.cpp
    M src/actions/advancement.hpp
    M src/actions/attack.cpp
    M src/actions/attack.hpp
    M src/ai/actions.cpp
    M src/ai/actions.hpp
    M src/ai/contexts.cpp
    M src/ai/lua/core.cpp

  Log Message:
  -----------
  remove ai advancement parameter from attack_and_advance

celmin confirmed that it is no longer needed


Compare: https://github.com/wesnoth/wesnoth/compare/f3ed41d728e6...f40a51c3ef1e