[wesnoth-commits] [wesnoth/wesnoth] 2f54ec: fix display chat messages disappearing

[gfgtdf]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 2f54ecbc53abe69a294b5384b974537d84efa80d
      https://github.com/wesnoth/wesnoth/commit/2f54ecbc53abe69a294b5384b974537d84efa80d
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2019-02-08 (Fri, 08 Feb 2019)

  Changed paths:
    M src/display_chat_manager.cpp

  Log Message:
  -----------
  fix display chat messages disappearing

Previously `message_aging != 0` was not checked for each chat message resulting in all messages to be cleared when there is no space left.

Also when SDL_GetTicks() of the latest chatmessage returned a different value than when it was constructed the just added chatmessage was cleared aswell.

This commit also refactors to make sure SDL_GetTicks() is only called once there becasue it might be a rather slow operation (depending on plattform depended implementation).