[wesnoth-commits] [wesnoth/wesnoth] 9bc616: Strip usernames used in the MP UI and command line...

[Iris Morelle]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 9bc6161c3c5baf6d06f7cd4d78797ed760dcfa2c
      https://github.com/wesnoth/wesnoth/commit/9bc6161c3c5baf6d06f7cd4d78797ed760dcfa2c
  Author: Iris Morelle <shadowm at wesnoth.org>
  Date:   2019-02-12 (Tue, 12 Feb 2019)

  Changed paths:
    M changelog.md
    M src/preferences/credentials.cpp

  Log Message:
  -----------
  Strip usernames used in the MP UI and command line of trailing whitespace

This also affects line breaks. There's no point in displaying confusing
errors to the player in the off-chance that they manage to introduce
leading or trailing whitespace in the username field. The server doesn't
accept whitespace but that doesn't mean we can't try to guess what the
user really meant to do, and extra whitespace around a name is a pretty
trivial mistake to make.

The password field, on the other hand, ought to accept it since it's
possible to even have line break characters in it (as tested with
Firefox on the live phpBB registration form for forums.w.o).