[wesnoth-commits] [wesnoth/wesnoth] ace1b0: Fix addon manager crash if not finding the add-on ...

GitHub noreply at github.com
Thu Jan 17 23:55:53 UTC 2019


  Branch: refs/heads/1.14
  Home:   https://github.com/wesnoth/wesnoth
  Commit: ace1b01da1048a5b4fc457487ca4e50320901f23
      https://github.com/wesnoth/wesnoth/commit/ace1b01da1048a5b4fc457487ca4e50320901f23
  Author: Lovens Weche <lweche159 at gmail.com>
  Date:   2019-01-18 (Fri, 18 Jan 2019)

  Changed paths:
    M data/tools/wesnoth_addon_manager

  Log Message:
  -----------
  Fix addon manager crash if not finding the add-on (#3874)

* Fix addon manager crash if not finding the add-on

In the addon manager, there was no validation code for paths in the file
system for uploading addons. This fix adds validation at the parsing
level, so that the original code is left unchanged.

* Fixes for addon manager crash commit

Fixes include:

1. Spaces kept instead of tabs.
2. printf-style String Formatting is used since it seems to be compatible
with nearly all versions of Python.
3. A trailing line break was added to the formatted string.


  Commit: 1e00ff83b4febd610ecbd8fe1886e227f784c787
      https://github.com/wesnoth/wesnoth/commit/1e00ff83b4febd610ecbd8fe1886e227f784c787
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2019-01-18 (Fri, 18 Jan 2019)

  Changed paths:
    M data/gui/macros/_initial.cfg
    M data/gui/window/addon_manager.cfg
    M data/gui/window/chat_log.cfg
    M data/gui/window/game_load.cfg
    M data/gui/window/lobby_main.cfg
    M data/gui/window/mp_create_game.cfg
    M data/gui/window/preferences/02_hotkeys.cfg
    M data/gui/window/unit_create.cfg
    M data/gui/window/unit_recall.cfg
    M data/gui/window/unit_recruit.cfg

  Log Message:
  -----------
  GUI2: fixed typo in macro name (pointed out in #3847)

[ci skip]


Compare: https://github.com/wesnoth/wesnoth/compare/4679e55f3319...1e00ff83b4fe
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the Commits mailing list