[wesnoth-commits] [wesnoth/wesnoth] e0aa68: Disallow creating variables with invalid WML tag n...

[GitHub]

  Branch: refs/heads/1.14
  Home:   https://github.com/wesnoth/wesnoth
  Commit: e0aa686ff2fb65382407d32e02d16f5a8afda7ab
      https://github.com/wesnoth/wesnoth/commit/e0aa686ff2fb65382407d32e02d16f5a8afda7ab
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2019-01-18 (Fri, 18 Jan 2019)

  Changed paths:
    M src/variable_info_detail.hpp

  Log Message:
  -----------
  Disallow creating variables with invalid WML tag names (fixes #3877)

Variables are saved as WML elements, and as such, variable names must also
be valid WML tag names.


  Commit: 07bf003b7990047a55e8d3031ffeb4f937295830
      https://github.com/wesnoth/wesnoth/commit/07bf003b7990047a55e8d3031ffeb4f937295830
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2019-01-18 (Fri, 18 Jan 2019)

  Changed paths:
    M src/config.cpp
    M src/scripting/lua_common.cpp

  Log Message:
  -----------
  Allow WML tags with leading underscore (#3877)

@gfgtdf pointed out that the WML parser can deal with such tags after all.
I had missed that when I implemented the check that the game state is
valid WML before saving it (commit 3bc36efa5898a95ce793195e24b4dee1b546c222).

Such tags are still disallowed in the Lua API because allowing them would
be an API change.


Compare: https://github.com/wesnoth/wesnoth/compare/e57ecf4bb5df...07bf003b7990
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.