[wesnoth-commits] [wesnoth/wesnoth] ccedb5: WML attribute names must also be valid tag names
GitHub
noreply at github.com
Sat Jan 19 15:31:05 UTC 2019
Branch: refs/heads/master
Home: https://github.com/wesnoth/wesnoth
Commit: ccedb51101a695b776a38c61e672a2506a6f5bc3
https://github.com/wesnoth/wesnoth/commit/ccedb51101a695b776a38c61e672a2506a6f5bc3
Author: Jyrki Vesterinen <sandgtx at gmail.com>
Date: 2019-01-19 (Sat, 19 Jan 2019)
Changed paths:
M src/config.cpp
Log Message:
-----------
WML attribute names must also be valid tag names
"_" isn't a valid attribute name, either.
I also made config::validate_wml() check attribute names in addition to
just the tag names.
Commit: f0990e2d7af33d0e7c929030d3ed8194a446ef8c
https://github.com/wesnoth/wesnoth/commit/f0990e2d7af33d0e7c929030d3ed8194a446ef8c
Author: Jyrki Vesterinen <sandgtx at gmail.com>
Date: 2019-01-19 (Sat, 19 Jan 2019)
Changed paths:
M src/variable_info_detail.hpp
Log Message:
-----------
Revert "Disallow creating variables with invalid WML tag names (fixes #3877)"
This reverts commit 736f217793368fa27d180ed4dc5818072319d528.
The check is redundant with the one in get_variable_key_visitor
constructor.
Compare: https://github.com/wesnoth/wesnoth/compare/81d0d2214a85...f0990e2d7af3
**NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/
Functionality will be removed from GitHub.com on January 31st, 2019.
More information about the Commits
mailing list