[wesnoth-commits] [wesnoth/wesnoth] dc18d6: Fix item names in the scenario editor not being lo...

[GitHub]

  Branch: refs/heads/1.14
  Home:   https://github.com/wesnoth/wesnoth
  Commit: dc18d65e04764c6b68085e560ac9626fcc3fc4c7
      https://github.com/wesnoth/wesnoth/commit/dc18d65e04764c6b68085e560ac9626fcc3fc4c7
  Author: Iris Morelle <shadowm at wesnoth.org>
  Date:   2019-01-26 (Sat, 26 Jan 2019)

  Changed paths:
    M changelog.md
    M data/core/editor/items.cfg

  Log Message:
  -----------
  Fix item names in the scenario editor not being localized

data/core/editor/items.cfg defines the names for the items. The file is
included by data/core/editor/_main.cfg, which has a #textdomain binding
to wesnoth-editor at the top. The strings end up bound to that
textdomain by the game, but wmlxgettext doesn’t have any way to see this
so it binds them to the default textdomain instead, which is wesnoth,
not wesnoth-editor. The game ends up looking for the strings in
wesnoth-editor instead.

The easiest solution right now is to explicitly bind items.cfg to the
wesnoth textdomain so as to not require moving catalogue entries in the
po files around to wesnoth-editor. It really should've been
wesnoth-editor in the first place but it's too late to fix that now
without giving translators a migraine. It's a pity either way given how
useless the scenario editor is in practice.

[ci skip]



      **NOTE:** GitHub Services has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      We will provide an alternative path for the email notifications by January 31st, 2019.