[wesnoth-commits] [wesnoth/wesnoth] 38641d: Hit stats: Track number of hits/misses by CTH in s...

Tue Jun 11 08:51:05 UTC 2019

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 38641d667a4d08557b008a6e0b3045f6789b356a
      https://github.com/wesnoth/wesnoth/commit/38641d667a4d08557b008a6e0b3045f6789b356a
  Author: josteph <josteph at fastmail.com>
  Date:   2019-06-05 (Wed, 05 Jun 2019)

  Changed paths:
    M src/actions/attack.cpp
    M src/statistics.cpp
    M src/statistics.hpp

  Log Message:
  -----------
  Hit stats: Track number of hits/misses by CTH in statistics::stats objects.

  Commit: ed22925dd137c89b1a0e7aac84dd65a9ab752e03
      https://github.com/wesnoth/wesnoth/commit/ed22925dd137c89b1a0e7aac84dd65a9ab752e03
  Author: josteph <josteph at fastmail.com>
  Date:   2019-06-05 (Wed, 05 Jun 2019)

  Changed paths:
    M data/gui/window/statistics_dialog.cfg
    M src/gui/dialogs/statistics_dialog.cpp
    M src/gui/dialogs/statistics_dialog.hpp

  Log Message:
  -----------
  Hit stats: Show number of hits/misses inflicted overall in statistics dialog.

  Commit: 7eb75539a6efc142f2d6733c3f60b2d2f1827e99
      https://github.com/wesnoth/wesnoth/commit/7eb75539a6efc142f2d6733c3f60b2d2f1827e99
  Author: josteph <josteph at fastmail.com>
  Date:   2019-06-05 (Wed, 05 Jun 2019)

  Changed paths:
    M src/gui/dialogs/statistics_dialog.cpp
    M src/statistics.cpp
    M src/statistics.hpp

  Log Message:
  -----------
  Hit stats: Track both inflicted and taken hits.

  Commit: b52eb32ba21244e298359f932c72426ecb7ed6ad
      https://github.com/wesnoth/wesnoth/commit/b52eb32ba21244e298359f932c72426ecb7ed6ad
  Author: josteph <josteph at fastmail.com>
  Date:   2019-06-05 (Wed, 05 Jun 2019)

  Changed paths:
    M src/statistics.cpp
    M src/statistics.hpp

  Log Message:
  -----------
  Hit stats: Save and restore hit stats.

  Commit: 494bdc51f73ae0365bf0564ce8b8de02d3568e9a
      https://github.com/wesnoth/wesnoth/commit/494bdc51f73ae0365bf0564ce8b8de02d3568e9a
  Author: josteph <josteph at fastmail.com>
  Date:   2019-06-05 (Wed, 05 Jun 2019)

  Changed paths:
    M src/gui/dialogs/statistics_dialog.cpp
    M src/gui/dialogs/statistics_dialog.hpp
    M src/statistics.cpp
    M src/statistics.hpp

  Log Message:
  -----------
  Hit stats: Track current turn stats too.

  Commit: d5874ea81c446af2049d9e0712b42ef98d6e0e3c
      https://github.com/wesnoth/wesnoth/commit/d5874ea81c446af2049d9e0712b42ef98d6e0e3c
  Author: josteph <josteph at fastmail.com>
  Date:   2019-06-05 (Wed, 05 Jun 2019)

  Changed paths:
    M data/gui/window/statistics_dialog.cfg
    M src/actions/attack.hpp
    M src/gui/dialogs/statistics_dialog.cpp

  Log Message:
  -----------
  Hit stats: Show the probability of being at least this far from the mean.

  Commit: f5d68f9d41758018c5c94436992df60778e66013
      https://github.com/wesnoth/wesnoth/commit/f5d68f9d41758018c5c94436992df60778e66013
  Author: josteph <josteph at fastmail.com>
  Date:   2019-06-05 (Wed, 05 Jun 2019)

  Changed paths:
    M data/gui/window/statistics_dialog.cfg
    M src/gui/dialogs/statistics_dialog.cpp

  Log Message:
  -----------
  Stats dialog: Split the "1/2 3%" column into two separate columns, one for "1/2" and one for "3%".

The percentages align vertically now, but the intercolumn spacing is
still somewhat hacky.

  Commit: 0e3877e3b18d4aa0bda306736fbddf7fcd6b0ff0
      https://github.com/wesnoth/wesnoth/commit/0e3877e3b18d4aa0bda306736fbddf7fcd6b0ff0
  Author: josteph <josteph at fastmail.com>
  Date:   2019-06-05 (Wed, 05 Jun 2019)

  Changed paths:
    M data/gui/window/statistics_dialog.cfg

  Log Message:
  -----------
  Stats dialog: Add tooltips to the damage and hits tables.

  Commit: 479be6e61b1a4867b33ec0aa19498dd8ef0b6b32
      https://github.com/wesnoth/wesnoth/commit/479be6e61b1a4867b33ec0aa19498dd8ef0b6b32
  Author: josteph <josteph at fastmail.com>
  Date:   2019-06-05 (Wed, 05 Jun 2019)

  Changed paths:
    M src/statistics.cpp
    M src/statistics.hpp

  Log Message:
  -----------
  statistics: Rename a class member

To match the convention. The next commit adds the *_taken member.

  Commit: 13cf420adbb1ae1deb69bb89a017b4e8a5399798
      https://github.com/wesnoth/wesnoth/commit/13cf420adbb1ae1deb69bb89a017b4e8a5399798
  Author: josteph <josteph at fastmail.com>
  Date:   2019-06-05 (Wed, 05 Jun 2019)

  Changed paths:
    M src/statistics.cpp
    M src/statistics.hpp

  Log Message:
  -----------
  statistics: Add attacks_taken, defends_taken

They'll be used to reconstruct by_cth_taken, like
attacks_inflicted/defends_inflicted will be used to reconstruct
by_cth_inflicted.

  Commit: 24b59cb2bfba8de5816c5d06de91f7a744843d86
      https://github.com/wesnoth/wesnoth/commit/24b59cb2bfba8de5816c5d06de91f7a744843d86
  Author: josteph <josteph at fastmail.com>
  Date:   2019-06-05 (Wed, 05 Jun 2019)

  Changed paths:
    M src/statistics.cpp

  Log Message:
  -----------
  Hit stats: Don't serialize by_cth_inflicted/by_cth_taken

They're superfluous in the savefile; their values can be deserialized from the
existing [attacks]/[defends] tags and the new [attacks_taken]/[defends_taken]
info.

  Commit: 5f34300bf9305238bb0d1b832b1b28ca73907825
      https://github.com/wesnoth/wesnoth/commit/5f34300bf9305238bb0d1b832b1b28ca73907825
  Author: josteph <josteph at fastmail.com>
  Date:   2019-06-05 (Wed, 05 Jun 2019)

  Changed paths:
    M src/gui/dialogs/statistics_dialog.cpp
    M src/gui/dialogs/statistics_dialog.hpp
    M src/statistics.cpp
    M src/statistics.hpp

  Log Message:
  -----------
  Hit stats: Introduce a hitrate_map typedef.

  Commit: ff5df5141eeb8355585305943584949dfbc6c010
      https://github.com/wesnoth/wesnoth/commit/ff5df5141eeb8355585305943584949dfbc6c010
  Author: josteph <josteph at fastmail.com>
  Date:   2019-06-05 (Wed, 05 Jun 2019)

  Changed paths:
    M data/gui/window/statistics_dialog.cfg
    M src/gui/dialogs/statistics_dialog.cpp
    M src/statistics.cpp
    M src/statistics.hpp

  Log Message:
  -----------
  statistics: Coding style changes suggested by @jyrkive.

  Commit: bad65044dc2edb18147f8c3c79470127409141fc
      https://github.com/wesnoth/wesnoth/commit/bad65044dc2edb18147f8c3c79470127409141fc
  Author: josteph <josteph at fastmail.com>
  Date:   2019-06-05 (Wed, 05 Jun 2019)

  Changed paths:
    M src/statistics.cpp
    M src/statistics.hpp

  Log Message:
  -----------
  Hit stats: Rename a type to reflect its content rather than its use

  Commit: 147f3798cb4d0ebd7cf6f2200cf152d513971ce9
      https://github.com/wesnoth/wesnoth/commit/147f3798cb4d0ebd7cf6f2200cf152d513971ce9
  Author: josteph <josteph at fastmail.com>
  Date:   2019-06-05 (Wed, 05 Jun 2019)

  Changed paths:
    M src/gui/dialogs/statistics_dialog.cpp

  Log Message:
  -----------
  Hit stats: Use a custom type instead of a pair

  Commit: 584716054a231204a3e55a914064b2f875cb305e
      https://github.com/wesnoth/wesnoth/commit/584716054a231204a3e55a914064b2f875cb305e
  Author: josteph <josteph at fastmail.com>
  Date:   2019-06-05 (Wed, 05 Jun 2019)

  Changed paths:
    M src/statistics.cpp

  Log Message:
  -----------
  Hit stats: Change serialization keys/values

https://github.com/wesnoth/wesnoth/pull/4070#discussion_r283119711

  Commit: 949d77f950a77faed687bc7790a058c5a9df8ad7
      https://github.com/wesnoth/wesnoth/commit/949d77f950a77faed687bc7790a058c5a9df8ad7
  Author: josteph <josteph at fastmail.com>
  Date:   2019-06-05 (Wed, 05 Jun 2019)

  Changed paths:
    M src/statistics.cpp

  Log Message:
  -----------
  statistics: Avoid magic strings

https://github.com/wesnoth/wesnoth/pull/4070#discussion_r283444754

  Commit: ea2be9919e905e582973ff93493ae810e0b35f52
      https://github.com/wesnoth/wesnoth/commit/ea2be9919e905e582973ff93493ae810e0b35f52
  Author: josteph <josteph at fastmail.com>
  Date:   2019-06-05 (Wed, 05 Jun 2019)

  Changed paths:
    M src/statistics.cpp

  Log Message:
  -----------
  statistics: Simplify expression.

Thanks @jyrkive

  Commit: d451238b253286e062dd0d99c9e006d12e9d115b
      https://github.com/wesnoth/wesnoth/commit/d451238b253286e062dd0d99c9e006d12e9d115b
  Author: josteph <josteph at fastmail.com>
  Date:   2019-06-05 (Wed, 05 Jun 2019)

  Changed paths:
    M data/gui/window/statistics_dialog.cfg
    M src/gui/dialogs/statistics_dialog.cpp

  Log Message:
  -----------
  statistics_dialog: Fix wrong uses of linked_group

Remove extraneous columns, add grids in the bottom two tables where it's
needed for two columns to match the width of one column of the first
table.

  Commit: d76a7ba5d09ca4d8d847a42cb9ca8f1758ac5153
      https://github.com/wesnoth/wesnoth/commit/d76a7ba5d09ca4d8d847a42cb9ca8f1758ac5153
  Author: josteph <josteph at fastmail.com>
  Date:   2019-06-05 (Wed, 05 Jun 2019)

  Changed paths:
    M CMakeLists.txt
    M SConstruct

  Log Message:
  -----------
  Disable -Wunused-lambda-capture on clang.

In a nutshell, capturing a local "const constexpr int foo;" variable
with [foo](){} warns on clang that the program would be valid even if
the square brackets had been left empty, but making them so warns on
VC15.  See
https://stackoverflow.com/questions/52416362/unused-lambda-capture-warning-when-capture-is-actually-used

Disable the warning since explicitly capturing foo is good practice.

  Commit: 651615f979c97a2dd0d0e723657161ba4b165f44
      https://github.com/wesnoth/wesnoth/commit/651615f979c97a2dd0d0e723657161ba4b165f44
  Author: josteph <josteph at fastmail.com>
  Date:   2019-06-05 (Wed, 05 Jun 2019)

  Changed paths:
    M src/gui/dialogs/statistics_dialog.cpp

  Log Message:
  -----------
  statistics_dialog: Deduplicate code.

  Commit: a932ebee588e43de73a9c2f30e9834877411caf1
      https://github.com/wesnoth/wesnoth/commit/a932ebee588e43de73a9c2f30e9834877411caf1
  Author: josteph <josteph at fastmail.com>
  Date:   2019-06-05 (Wed, 05 Jun 2019)

  Changed paths:
    M data/gui/window/statistics_dialog.cfg
    M src/gui/dialogs/statistics_dialog.cpp

  Log Message:
  -----------
  statistics_dialog: Change the percentages in the "Hits" table

Make the contents of the table cell the same regardless of whether
actual<expected or actual>expected.  For example, 2 hits out of
4 strikes at 70% now shows "8.4%, 26.5%, 65.1%", which are the
probabilities of hitting less than twice, exactly twice, and more than
twice, respectively.

Color has been temporarily removed, will be restored in the next commit.

  Commit: 061edc2bb300a6c810992a7c0a1e21c9c3f93e39
      https://github.com/wesnoth/wesnoth/commit/061edc2bb300a6c810992a7c0a1e21c9c3f93e39
  Author: josteph <josteph at fastmail.com>
  Date:   2019-06-05 (Wed, 05 Jun 2019)

  Changed paths:
    M src/gui/dialogs/statistics_dialog.cpp
    M src/gui/dialogs/statistics_dialog.hpp

  Log Message:
  -----------
  statistics_dialog: Restore color in the hits table

The color scale is reversed between Taken and Inflicted:

Row           Color of "hitting less than actual"    Color of "hitting more than actual"
---           -----------------------------------    -----------------------------------
Inflicted     green to red                           red to green
Taken         red to green                           green to red

This way, in both rows green means "It could have been better" and red
means "It could have been worse". Basically, green means the RNG
favored the enemy sides, and red means the RNG favored the current side.

The _a priori_ probability of the actual result is intentionally left uncolored.

  Commit: e2638c9d84e4ae52c54a114d16128654d838ae9b
      https://github.com/wesnoth/wesnoth/commit/e2638c9d84e4ae52c54a114d16128654d838ae9b
  Author: josteph <josteph at fastmail.com>
  Date:   2019-06-05 (Wed, 05 Jun 2019)

  Changed paths:
    M data/gui/window/statistics_dialog.cfg
    M src/gui/dialogs/statistics_dialog.cpp

  Log Message:
  -----------
  statistics_dialog: Don't show probability of the actual result

To simplify the stats dialog, show two percentages, instead of three
percentages that add up to 100%.

https://github.com/wesnoth/wesnoth/pull/4070#discussion_r285874571

  Commit: e64c7ed591f26ae7218252386dd30ee171bd080e
      https://github.com/wesnoth/wesnoth/commit/e64c7ed591f26ae7218252386dd30ee171bd080e
  Author: josteph <josteph at fastmail.com>
  Date:   2019-06-05 (Wed, 05 Jun 2019)

  Changed paths:
    M data/gui/window/statistics_dialog.cfg

  Log Message:
  -----------
  statistics_dialog: Attempt to fix missing left padding before the first column

Currently warns: "error validation: Invalid value '-5' in key 'border_size=' in tag [column]"

... but it looks correct.

  Commit: 111cb0f188721f5fbf778573bdde15400ba0e46e
      https://github.com/wesnoth/wesnoth/commit/111cb0f188721f5fbf778573bdde15400ba0e46e
  Author: josteph <josteph at fastmail.com>
  Date:   2019-06-05 (Wed, 05 Jun 2019)

  Changed paths:
    M data/gui/window/statistics_dialog.cfg

  Log Message:
  -----------
  statistics_dialog: Use uppercase for macro arguments.

https://github.com/wesnoth/wesnoth/pull/4070#discussion_r290086918

  Commit: d6b30f044ddc28a0ff0242b89baefa3f007a84f2
      https://github.com/wesnoth/wesnoth/commit/d6b30f044ddc28a0ff0242b89baefa3f007a84f2
  Author: josteph <josteph at fastmail.com>
  Date:   2019-06-05 (Wed, 05 Jun 2019)

  Changed paths:
    M src/gui/dialogs/statistics_dialog.cpp

  Log Message:
  -----------
  statistics_dialog: Don't reference temporaries.

https://github.com/wesnoth/wesnoth/pull/4070#discussion_r290087271

  Commit: 869c5a43a5348298b768743e004726f4e61e43cc
      https://github.com/wesnoth/wesnoth/commit/869c5a43a5348298b768743e004726f4e61e43cc
  Author: josteph <josteph at fastmail.com>
  Date:   2019-06-05 (Wed, 05 Jun 2019)

  Changed paths:
    M src/gui/dialogs/statistics_dialog.cpp

  Log Message:
  -----------
  statistics_dialog: More of "Don't reference temporaries".

https://github.com/wesnoth/wesnoth/pull/4070#discussion_r290087271

  Commit: 541956343bf86e1ecc526115b1a9b6f362067114
      https://github.com/wesnoth/wesnoth/commit/541956343bf86e1ecc526115b1a9b6f362067114
  Author: josteph <josteph at fastmail.com>
  Date:   2019-06-05 (Wed, 05 Jun 2019)

  Changed paths:
    M src/gui/dialogs/statistics_dialog.cpp
    M src/statistics.hpp

  Log Message:
  -----------
  Code formatting changes.

https://github.com/wesnoth/wesnoth/pull/4070#discussion_r290087376
https://github.com/wesnoth/wesnoth/pull/4070#discussion_r290087461

  Commit: 4fb2aaa7ab0bfe0e86ede7eb4a0da51fa41c73e7
      https://github.com/wesnoth/wesnoth/commit/4fb2aaa7ab0bfe0e86ede7eb4a0da51fa41c73e7
  Author: josteph <josteph at fastmail.com>
  Date:   2019-06-05 (Wed, 05 Jun 2019)

  Changed paths:
    M src/statistics.cpp

  Log Message:
  -----------
  Another code style change.

https://github.com/wesnoth/wesnoth/pull/4070#discussion_r290087743

  Commit: 68f8e5fb16b94d10a07dbc9e5d6770d087229897
      https://github.com/wesnoth/wesnoth/commit/68f8e5fb16b94d10a07dbc9e5d6770d087229897
  Author: josteph <josteph at fastmail.com>
  Date:   2019-06-11 (Tue, 11 Jun 2019)

  Changed paths:
    M data/gui/window/statistics_dialog.cfg

  Log Message:
  -----------
  fixup! statistics_dialog: Attempt to fix missing left padding before the first column

Fixes validation errors: "Invalid value '-5' in key 'border_size=' in tag [column]"

  Commit: e27ddf7535dbcd49ca0d1f2832c3ed9539bb7997
      https://github.com/wesnoth/wesnoth/commit/e27ddf7535dbcd49ca0d1f2832c3ed9539bb7997
  Author: jostephd <josteph at fastmail.com>
  Date:   2019-06-11 (Tue, 11 Jun 2019)

  Changed paths:
    M CMakeLists.txt
    M SConstruct
    M data/gui/window/statistics_dialog.cfg
    M src/actions/attack.cpp
    M src/actions/attack.hpp
    M src/gui/dialogs/statistics_dialog.cpp
    M src/gui/dialogs/statistics_dialog.hpp
    M src/statistics.cpp
    M src/statistics.hpp

  Log Message:
  -----------
  Merge pull request #4070 from jostephd/hit-rate-histogram

Add actual/expected hit count stats to stats dialog

Compare: https://github.com/wesnoth/wesnoth/compare/a471392c377a...e27ddf7535db