[wesnoth-commits] [wesnoth/wesnoth] daf054: support item_name= in [store_items]

[gfgtdf]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: daf054752a35d8395c2171b5bb5e8eb0e6407f10
      https://github.com/wesnoth/wesnoth/commit/daf054752a35d8395c2171b5bb5e8eb0e6407f10
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2019-03-20 (Wed, 20 Mar 2019)

  Changed paths:
    M data/campaigns/Secrets_of_the_Ancients/scenarios/16_The_Mage.cfg
    M data/lua/wml/items.lua
    M data/schema/core/actionwml.cfg

  Log Message:
  -----------
  support item_name= in [store_items]

we use it in SotA16 to make the scenario more robust against
[modification]s that might add [item]s for decoration.


  Commit: 3c172f73038aa9b5574bd924048c651f14b18a80
      https://github.com/wesnoth/wesnoth/commit/3c172f73038aa9b5574bd924048c651f14b18a80
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2019-03-20 (Wed, 20 Mar 2019)

  Changed paths:
    M src/carryover.cpp
    M src/game_events/menu_item.cpp
    M src/game_events/menu_item.hpp

  Log Message:
  -----------
  add [set_menu_item] persistent=yes/no

fixes #3844


  Commit: e4c4ca7572b2986790f40ee20b1ccb2e6e85252a
      https://github.com/wesnoth/wesnoth/commit/e4c4ca7572b2986790f40ee20b1ccb2e6e85252a
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2019-03-20 (Wed, 20 Mar 2019)

  Changed paths:
    M src/play_controller.cpp
    M src/saved_game.cpp
    M src/units/types.cpp
    M src/units/types.hpp

  Log Message:
  -----------
  add [unit_type_fix] in [scenario], [era] etc

fixes #1451

Currently advancements can be changed in two ways:
1) Via [advancefrom], this causes OOS in multiplayer
2) Via certain campaign etra defines, this has other disadvantages see

The new [unit_type_fix] that is accepted in [scenario], [multiplayer],
[era], [modification] , [campaign] and [ressource] changes the advancement
of a unit type only for one game and has non of the disadvantages of
the other two methods.

We should also deprecate the other two methods.


Compare: https://github.com/wesnoth/wesnoth/compare/0f1d70dbdcb5...e4c4ca7572b2