[wesnoth-commits] [wesnoth/wesnoth] 845a45: gui2/game_version: Increase maximum dialog height

[Iris Morelle]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 845a45da32657f62175517949a1d14187a60edb8
      https://github.com/wesnoth/wesnoth/commit/845a45da32657f62175517949a1d14187a60edb8
  Author: Iris Morelle <shadowm at wesnoth.org>
  Date:   2019-11-10 (Sun, 10 Nov 2019)

  Changed paths:
    M data/gui/window/game_version.cfg

  Log Message:
  -----------
  gui2/game_version: Increase maximum dialog height

I can see this dialog running out of vertical space on my Wine
configuration and winding up a victim of the dreaded Dialog-Wide
Scrollbar Syndrome.

[ci skip]


  Commit: f4ca974cd1fe25599e0c265809f2a1a0469bb15b
      https://github.com/wesnoth/wesnoth/commit/f4ca974cd1fe25599e0c265809f2a1a0469bb15b
  Author: Iris Morelle <shadowm at wesnoth.org>
  Date:   2019-11-10 (Sun, 10 Nov 2019)

  Changed paths:
    M data/gui/window/campaign_dialog.cfg
    M data/gui/window/campaign_difficulty.cfg
    M data/themes/_initial.cfg

  Log Message:
  -----------
  Disambiguate uses of the Play button label

This extends to a few other button labels used for replay control. While
checking if commit 46dbbc06c967bfc8ee5acb6525e1f1bd96b53005 was fit for
backporting to 1.14 I found out that "Play" was already in use
exclusively for one of the replay control buttons (which means, no, it
can't be backported). This makes the disambiguation markers absolutely
necessary.

To give a more practical example of why this is a big deal, in Spanish,
"Play" would be translated as "Jugar" in the context of the Campaigns
menu, and "Reproducir" in the context of a replay (or movie). The
Spanish translation in fact already uses the latter in both 1.14 and
master.

[ci skip]


Compare: https://github.com/wesnoth/wesnoth/compare/399575278246...f4ca974cd1fe