[wesnoth-commits] [wesnoth/wesnoth] 534549: recruit: Show a transient message if repeating a r...

[jostephd]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 534549daa3741ff3f6cd5647c19485c8e1bae7de
      https://github.com/wesnoth/wesnoth/commit/534549daa3741ff3f6cd5647c19485c8e1bae7de
  Author: josteph <josteph at fastmail.com>
  Date:   2019-10-16 (Wed, 16 Oct 2019)

  Changed paths:
    M src/menu_events.cpp

  Log Message:
  -----------
  recruit: Show a transient message if repeating a recruit failed

Reproducible in WoV S3 by recruiting a unit and trying to repeat the recruit.
Previously it failed silently, now it shows a message.


  Commit: eaf67247400d301063b227ea35934f068d74f3f9
      https://github.com/wesnoth/wesnoth/commit/eaf67247400d301063b227ea35934f068d74f3f9
  Author: josteph <josteph at fastmail.com>
  Date:   2019-10-16 (Wed, 16 Oct 2019)

  Changed paths:
    M src/menu_events.cpp
    M src/menu_events.hpp

  Log Message:
  -----------
  recruit: Add menu_handler::can_recruit that returns a reason

For #4443


  Commit: b3e04ba54debf1e9e96ba61dcf4626ef5bc193c4
      https://github.com/wesnoth/wesnoth/commit/b3e04ba54debf1e9e96ba61dcf4626ef5bc193c4
  Author: josteph <josteph at fastmail.com>
  Date:   2019-10-16 (Wed, 16 Oct 2019)

  Changed paths:
    M src/gui/dialogs/unit_recruit.hpp
    M src/menu_events.cpp

  Log Message:
  -----------
  unit_recruit: Minor refactoring


  Commit: 1fbf9d935610e9e363c2325064cb34f6178a05c8
      https://github.com/wesnoth/wesnoth/commit/1fbf9d935610e9e363c2325064cb34f6178a05c8
  Author: josteph <josteph at fastmail.com>
  Date:   2019-10-16 (Wed, 16 Oct 2019)

  Changed paths:
    M src/actions/create.cpp
    M src/gui/dialogs/unit_recruit.cpp
    M src/gui/dialogs/unit_recruit.hpp
    M src/menu_events.cpp

  Log Message:
  -----------
  unit_recruit: Gray out units that would not be able to be recruited

Fixes #4443


  Commit: c7adc3ad9f671773f45f504c691b98c100229e01
      https://github.com/wesnoth/wesnoth/commit/c7adc3ad9f671773f45f504c691b98c100229e01
  Author: josteph <josteph at fastmail.com>
  Date:   2019-10-16 (Wed, 16 Oct 2019)

  Changed paths:
    M src/gui/dialogs/unit_recruit.cpp
    M src/menu_events.cpp

  Log Message:
  -----------
  unit_recruit: Move the planning mode gold computation out of the dialog


  Commit: 9fdeebfa0e91d3f03ac156c89ae209dfa442eb49
      https://github.com/wesnoth/wesnoth/commit/9fdeebfa0e91d3f03ac156c89ae209dfa442eb49
  Author: josteph <josteph at fastmail.com>
  Date:   2019-10-16 (Wed, 16 Oct 2019)

  Changed paths:
    M src/gui/dialogs/unit_recruit.cpp

  Log Message:
  -----------
  unit_recruit: Rename variable


  Commit: 69f7ba660c150afdcbfab3d24bf205fff2af2407
      https://github.com/wesnoth/wesnoth/commit/69f7ba660c150afdcbfab3d24bf205fff2af2407
  Author: josteph <josteph at fastmail.com>
  Date:   2019-10-16 (Wed, 16 Oct 2019)

  Changed paths:
    M src/gui/dialogs/unit_recruit.hpp

  Log Message:
  -----------
  unit_recruit: Edit comments


  Commit: 129e53b660f868c3a9ddc548517ddc60474d2270
      https://github.com/wesnoth/wesnoth/commit/129e53b660f868c3a9ddc548517ddc60474d2270
  Author: josteph <josteph at fastmail.com>
  Date:   2019-10-16 (Wed, 16 Oct 2019)

  Changed paths:
    M src/gui/dialogs/unit_recruit.cpp
    M src/gui/dialogs/unit_recruit.hpp
    M src/menu_events.cpp
    M src/menu_events.hpp

  Log Message:
  -----------
  unit_recruit: Pass the error strings as t_string


  Commit: 70a2046f8f7f4c60e96245319d03b9aad4a40ec5
      https://github.com/wesnoth/wesnoth/commit/70a2046f8f7f4c60e96245319d03b9aad4a40ec5
  Author: josteph <josteph at fastmail.com>
  Date:   2019-10-16 (Wed, 16 Oct 2019)

  Changed paths:
    M changelog.md

  Log Message:
  -----------
  Add #4444 to changelog


Compare: https://github.com/wesnoth/wesnoth/compare/6b77280c28f4...70a2046f8f7f