[wesnoth-commits] [wesnoth/wesnoth] 9792af: Trigger an L4 deprecation message for [terrain_typ...

[Steve Cotton]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 9792af39b81935dafabd0e5ad931e6ea98a48bf3
      https://github.com/wesnoth/wesnoth/commit/9792af39b81935dafabd0e5ad931e6ea98a48bf3
  Author: Steve Cotton <steve at octalot.co.uk>
  Date:   2019-09-10 (Tue, 10 Sep 2019)

  Changed paths:
    M changelog.md
    M data/schema/terrain/types.cfg
    M src/terrain/terrain.cpp

  Log Message:
  -----------
  Trigger an L4 deprecation message for [terrain_type]vision_alias=

The feature was never added, a deprecation message saying that it's been
removed is the closest option to the situation. While terrain.cpp itself
supports vision_alias, it was never added to the calculations in movetype.cpp,
therefore it never affected units' vision. It's also not shown in the help
about the terrain.

This doesn't affect the features of units having vision costs different to
movement costs, or of units having a different number of vision points to
movement points, both of which are still supported.

While I'd encourage anyone who wants to implement vision_alias to do so, at the
moment I feel that the still-supported features in the same area haven't been
explored yet, and that vision_alias isn't going to developed before 1.16.0 is
released.