[wesnoth-commits] [wesnoth/wesnoth] ccd006: Refactored handling of advanced preferences

[Charles Dang]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: ccd006cccdf1368b731a93b45a825ad1c96b6fc8
      https://github.com/wesnoth/wesnoth/commit/ccd006cccdf1368b731a93b45a825ad1c96b6fc8
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2020-12-14 (Mon, 14 Dec 2020)

  Changed paths:
    M projectfiles/VC16/wesnoth.vcxproj
    M projectfiles/VC16/wesnoth.vcxproj.filters
    M source_lists/wesnoth
    M src/game_launcher.cpp
    M src/game_launcher.hpp
    M src/gui/dialogs/preferences_dialog.cpp
    M src/gui/dialogs/preferences_dialog.hpp
    A src/preferences/advanced.cpp
    A src/preferences/advanced.hpp
    M src/wesnoth.cpp

  Log Message:
  -----------
  Refactored handling of advanced preferences

Instead of having the preferences dialog make a copy of all advanced preference config objects (and sorting them)
every time you invoke it, this adds a new advanced_manager class instantiated once in game_launcher (not sure if
that's the best place for it, though) that parses and handles the options. Allows me to greatly clean up the
preferences dialog code.


  Commit: 3ae339bf3103982da550e6bc09be4c293c82112a
      https://github.com/wesnoth/wesnoth/commit/3ae339bf3103982da550e6bc09be4c293c82112a
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2020-12-14 (Mon, 14 Dec 2020)

  Changed paths:
    M src/chat_command_handler.cpp
    M src/editor/controller/editor_controller.cpp
    M src/game_launcher.cpp
    M src/gui/dialogs/multiplayer/lobby.cpp
    M src/gui/dialogs/preferences_dialog.cpp
    M src/gui/dialogs/preferences_dialog.hpp
    M src/menu_events.cpp

  Log Message:
  -----------
  GUI2/Preferences Dialog: removed now-unused game config ctor argument


Compare: https://github.com/wesnoth/wesnoth/compare/c8576a781da3...3ae339bf3103