[wesnoth-commits] [wesnoth/wesnoth] 3e2d0a: Unit: don't store advancements in a boost::ptr_vector

Charles Dang noreply at github.com
Tue Dec 15 16:21:24 UTC 2020


  Branch: refs/heads/no_ptr_vector
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 3e2d0ae67860bc99c0616ff5cd7022b7a2762567
      https://github.com/wesnoth/wesnoth/commit/3e2d0ae67860bc99c0616ff5cd7022b7a2762567
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2020-12-16 (Wed, 16 Dec 2020)

  Changed paths:
    M src/units/unit.cpp
    M src/units/unit.hpp

  Log Message:
  -----------
  Unit: don't store advancements in a boost::ptr_vector

I really have no idea why it was done this way, especially since it always seems to be allocating new config objects...?
Probably a relic of the pre-C++11 age.

Addresses one header brought up in #5359.


  Commit: 362b6d7fa69323fba8823ce1ce3c9103714790c0
      https://github.com/wesnoth/wesnoth/commit/362b6d7fa69323fba8823ce1ce3c9103714790c0
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2020-12-16 (Wed, 16 Dec 2020)

  Changed paths:
    M src/units/unit.cpp

  Log Message:
  -----------
  Unit: removed uses of this->member


Compare: https://github.com/wesnoth/wesnoth/compare/3e2d0ae67860%5E...362b6d7fa693



More information about the Commits mailing list