[wesnoth-commits] [wesnoth/wesnoth] a3ad18: FS: removed use of Windows-specific error code

Charles Dang noreply at github.com
Mon Dec 21 01:50:09 UTC 2020


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: a3ad181e6cd107b8c9dc9a7b0ddbd17e5241157e
      https://github.com/wesnoth/wesnoth/commit/a3ad181e6cd107b8c9dc9a7b0ddbd17e5241157e
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2020-12-17 (Thu, 17 Dec 2020)

  Changed paths:
    M src/filesystem.cpp

  Log Message:
  -----------
  FS: removed use of Windows-specific error code

The OS-specific error code headers were deprecated in Boost 1.75 (see #5359). This code was first added back in 2013
(see 037e1c12997fe92a2aed36c8b2a05ff31696e8de) but testing now on Windows 10 using Boost 1.73 at least shows that
`no_such_file_or_directory` is returned for both missing files and paths. Seems unnecessary to keep this case around
especially as the header is deprecated going forward.


  Commit: 2c6c9b56a5aaf9744e50cc3a478f615b830952dd
      https://github.com/wesnoth/wesnoth/commit/2c6c9b56a5aaf9744e50cc3a478f615b830952dd
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2020-12-17 (Thu, 17 Dec 2020)

  Changed paths:
    M src/filesystem.cpp

  Log Message:
  -----------
  Attempt fixup


  Commit: 95c6e6777b6c3367076ed3236cd0609e48acd605
      https://github.com/wesnoth/wesnoth/commit/95c6e6777b6c3367076ed3236cd0609e48acd605
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2020-12-21 (Mon, 21 Dec 2020)

  Changed paths:
    M src/filesystem.cpp

  Log Message:
  -----------
  Merge pull request #5367 from wesnoth/remove_windows_error_code

FS: removed use of Windows-specific error code


Compare: https://github.com/wesnoth/wesnoth/compare/ecd1d0ce551c...95c6e6777b6c



More information about the Commits mailing list