[wesnoth-commits] [wesnoth/wesnoth] 59e672: video: Expose a check for the status of the singleton

[Iris Morelle]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 59e6728c2a29d9a148a88ae5a6fc704b182431f1
      https://github.com/wesnoth/wesnoth/commit/59e6728c2a29d9a148a88ae5a6fc704b182431f1
  Author: Iris Morelle <shadowm at wesnoth.org>
  Date:   2020-06-15 (Mon, 15 Jun 2020)

  Changed paths:
    M src/video.hpp

  Log Message:
  -----------
  video: Expose a check for the status of the singleton

CVideo::get_singleton() unconditionally dereferences the thing, which is
UB if it happens to be a null pointer. We need to query whether the
singleton exists in the first place so we can't use that strategy.


  Commit: 2f1e2ddc5e3606781ee2f81c6feed882a055e6b0
      https://github.com/wesnoth/wesnoth/commit/2f1e2ddc5e3606781ee2f81c6feed882a055e6b0
  Author: Iris Morelle <shadowm at wesnoth.org>
  Date:   2020-06-15 (Mon, 15 Jun 2020)

  Changed paths:
    M src/video.cpp
    M src/video.hpp

  Log Message:
  -----------
  video: Expose dpi and window status getters

These are currently used directly in CVideo::video_settings_report(),
which we want to remove from this class and implement externally.

This commit also reworks get_dpi_scale_factor() to be implemented in
terms of get_dpi().


  Commit: e948f156b224d512414f49557114e53e1f18c69c
      https://github.com/wesnoth/wesnoth/commit/e948f156b224d512414f49557114e53e1f18c69c
  Author: Iris Morelle <shadowm at wesnoth.org>
  Date:   2020-06-15 (Mon, 15 Jun 2020)

  Changed paths:
    M src/build_info.cpp
    M src/video.cpp
    M src/video.hpp

  Log Message:
  -----------
  bi: Full refactoring of the clipboard report formatting logic

This makes all sections use a formatter class to deal with the issue of
keeping the first column's width consistent within each section (but not
across all sections), so that we don't run into inconveniences later in
the future if any section's entry labels change. It also allows us to
change the list formatting entirely in a single place rather than
multiple places if we ever decide to do so.

This also replaces CVideo::video_settings_report() with a similar but
slightly more detailed report using the new bi list formatter class to
make it look consistent with the other sections, implemented in the bi
module instead of CVideo.


  Commit: a88beb3fefa1619abe01a86efa4b33a708e0b346
      https://github.com/wesnoth/wesnoth/commit/a88beb3fefa1619abe01a86efa4b33a708e0b346
  Author: Iris Morelle <shadowm at wesnoth.org>
  Date:   2020-06-15 (Mon, 15 Jun 2020)

  Changed paths:
    M src/video.cpp

  Log Message:
  -----------
  video: Make MAGIC_DPI_SCALE_NUMBER a typed constant


Compare: https://github.com/wesnoth/wesnoth/compare/39f44fad5548...a88beb3fefa1