[wesnoth-commits] [wesnoth/wesnoth] 0efd35: move active_mods and mp_era to game_classification

[gfgtdf]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 0efd35acbcba45724be4737073dc7f77480ec781
      https://github.com/wesnoth/wesnoth/commit/0efd35acbcba45724be4737073dc7f77480ec781
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2020-06-29 (Mon, 29 Jun 2020)

  Changed paths:
    M src/game_classification.cpp
    M src/game_classification.hpp
    M src/game_initialization/create_engine.cpp
    M src/game_initialization/mp_game_utils.cpp
    M src/game_initialization/multiplayer.cpp
    M src/game_launcher.cpp
    M src/mp_game_settings.cpp
    M src/mp_game_settings.hpp
    M src/saved_game.cpp
    M src/scripting/game_lua_kernel.cpp
    M src/tests/test_mp_connect.cpp

  Log Message:
  -----------
  move active_mods and mp_era to game_classification

in particular because active_mod is no longer mp specific, but
also for technical reasons


  Commit: 5cecb11652ba08d9eda9a52520d3f90f7a8e1083
      https://github.com/wesnoth/wesnoth/commit/5cecb11652ba08d9eda9a52520d3f90f7a8e1083
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2020-06-29 (Mon, 29 Jun 2020)

  Changed paths:
    M src/units/types.cpp

  Log Message:
  -----------
  move code out of unit ctor

prepares a bigger refactor of the unit_types
code.


  Commit: 553b0bada6a2a571f7a6a47dd9b26ead71df57d5
      https://github.com/wesnoth/wesnoth/commit/553b0bada6a2a571f7a6a47dd9b26ead71df57d5
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2020-06-29 (Mon, 29 Jun 2020)

  Changed paths:
    M src/actions/attack.cpp
    M src/actions/undo_recruit_action.cpp
    M src/statistics.cpp
    M src/units/filter.cpp
    M src/units/types.cpp
    M src/units/types.hpp
    M src/units/unit.cpp
    M src/units/unit.hpp

  Log Message:
  -----------
  rename unit_type::base_id()

to parent_id() because it is
unrelated to [base_unit]


  Commit: a34cb53c3389bc088594c8f0218ecdc565077aef
      https://github.com/wesnoth/wesnoth/commit/a34cb53c3389bc088594c8f0218ecdc565077aef
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2020-06-29 (Mon, 29 Jun 2020)

  Changed paths:
    M src/units/types.cpp
    M src/units/types.hpp

  Log Message:
  -----------
  refactor unit_types construction

We change the code so that it now no longer
changes the game_config object, this prepares a
patch to disable unused addons during a game.


  Commit: 93aa2ca409287ea54f6bfd00af69d64a721b4b2c
      https://github.com/wesnoth/wesnoth/commit/93aa2ca409287ea54f6bfd00af69d64a721b4b2c
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2020-06-29 (Mon, 29 Jun 2020)

  Changed paths:
    M source_lists/libwesnoth_core
    M src/about.cpp
    M src/about.hpp
    M src/ai/configuration.cpp
    M src/ai/configuration.hpp
    M src/controller_base.cpp
    M src/controller_base.hpp
    M src/editor/controller/editor_controller.cpp
    M src/editor/controller/editor_controller.hpp
    M src/editor/map/context_manager.cpp
    M src/editor/map/context_manager.hpp
    M src/editor/map/editor_map.cpp
    M src/editor/map/editor_map.hpp
    M src/editor/map/map_context.cpp
    M src/editor/map/map_context.hpp
    M src/editor/palette/editor_palettes.hpp
    M src/editor/palette/item_palette.cpp
    M src/editor/palette/item_palette.hpp
    M src/editor/palette/location_palette.cpp
    M src/editor/palette/location_palette.hpp
    M src/editor/palette/palette_manager.cpp
    M src/editor/palette/palette_manager.hpp
    M src/editor/palette/terrain_palettes.cpp
    M src/editor/palette/terrain_palettes.hpp
    M src/editor/palette/unit_palette.cpp
    M src/editor/palette/unit_palette.hpp
    M src/editor/toolkit/editor_toolkit.cpp
    M src/editor/toolkit/editor_toolkit.hpp
    M src/filesystem.cpp
    M src/filesystem.hpp
    M src/game_config_manager.cpp
    M src/game_config_manager.hpp
    A src/game_config_view.cpp
    A src/game_config_view.hpp
    M src/game_initialization/connect_engine.cpp
    M src/game_initialization/connect_engine.hpp
    M src/game_initialization/create_engine.hpp
    M src/game_initialization/depcheck.cpp
    M src/game_initialization/depcheck.hpp
    M src/game_initialization/lobby_data.cpp
    M src/game_initialization/mp_game_utils.cpp
    M src/game_initialization/multiplayer.cpp
    M src/game_initialization/multiplayer.hpp
    M src/generators/default_map_generator_job.hpp
    M src/gui/dialogs/game_load.cpp
    M src/gui/dialogs/game_load.hpp
    M src/gui/dialogs/help_browser.hpp
    M src/gui/dialogs/multiplayer/lobby.cpp
    M src/gui/dialogs/multiplayer/lobby.hpp
    M src/gui/dialogs/multiplayer/mp_create_game.cpp
    M src/gui/dialogs/multiplayer/mp_create_game.hpp
    M src/gui/dialogs/preferences_dialog.cpp
    M src/gui/dialogs/preferences_dialog.hpp
    M src/gui/widgets/minimap.cpp
    M src/gui/widgets/minimap.hpp
    M src/help/help.cpp
    M src/help/help.hpp
    M src/help/help_impl.cpp
    M src/help/help_impl.hpp
    M src/hotkey/hotkey_item.cpp
    M src/hotkey/hotkey_item.hpp
    M src/language.cpp
    M src/language.hpp
    M src/menu_events.hpp
    M src/preferences/general.cpp
    M src/saved_game.cpp
    M src/savegame.cpp
    M src/savegame.hpp
    M src/scripting/game_lua_kernel.cpp
    M src/scripting/game_lua_kernel.hpp
    M src/terrain/builder.cpp
    M src/terrain/builder.hpp
    M src/terrain/type_data.cpp
    M src/terrain/type_data.hpp
    M src/tests/gui/test_gui2.cpp
    M src/tests/test_image_modifications.cpp
    M src/tests/utils/fake_display.cpp
    M src/tests/utils/game_config_manager_tests.cpp
    M src/theme.cpp
    M src/theme.hpp
    M src/units/types.cpp
    M src/units/types.hpp

  Log Message:
  -----------
  deploy new game_config_view object

the game_config_view object offers const
access to the game_config object, furthermore
it allows the game_config config object to be
replaced by a vector of config objects which
is what we will do later.


  Commit: b63a3be6785ae0f5a60ee5fafffbbe6b5fe2436b
      https://github.com/wesnoth/wesnoth/commit/b63a3be6785ae0f5a60ee5fafffbbe6b5fe2436b
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2020-06-29 (Mon, 29 Jun 2020)

  Changed paths:
    M src/game_config_manager.cpp
    M src/saved_game.cpp

  Log Message:
  -----------
  game_config_manger refactoring

This commit prepares a patch to disable unused
addons during a game. We try to reduce codes
that change the game_config config object.

In particular this removes a code that changes
the order of terrain graphics tag. This could
in theory break code that relied on that order
but afaik the terrain_graphics tags offers a
`precedence` that allows users to specify the
order in which terrain graphics are applied.
so no additional compatabiltiy code is needed.


  Commit: 5759404121215730cbd4ec899061317923e0ec6e
      https://github.com/wesnoth/wesnoth/commit/5759404121215730cbd4ec899061317923e0ec6e
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2020-06-29 (Mon, 29 Jun 2020)

  Changed paths:
    M src/game_classification.cpp
    M src/game_classification.hpp
    M src/game_config_manager.cpp
    M src/game_config_manager.hpp
    M src/game_initialization/connect_engine.cpp
    M src/game_initialization/create_engine.cpp
    M src/game_initialization/mp_game_utils.cpp
    M src/game_initialization/multiplayer.cpp
    M src/game_launcher.cpp
    M src/gui/dialogs/multiplayer/mp_join_game.cpp
    M src/saved_game.cpp
    M src/tests/test_mp_connect.cpp

  Log Message:
  -----------
  disable unused addons during a game

Now, during an active game, (that is: not during
campaign selection for example) the engine hides
all toplevel tags from addons that are not
involved in the current game. 'involved' here
means providing one of the [campaign], [scenario],
[era], [multiplayer], [modification] or [resource]
tags that are active in the current game.

Fixes #4832


  Commit: 45fec655c2e13b4655f154a1de85b31225184b44
      https://github.com/wesnoth/wesnoth/commit/45fec655c2e13b4655f154a1de85b31225184b44
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2020-06-29 (Mon, 29 Jun 2020)

  Changed paths:
    M src/savegame.cpp

  Log Message:
  -----------
  savagame compatibility

for 'move active_mods and mp_era to game_classification'


Compare: https://github.com/wesnoth/wesnoth/compare/8f9ab9d13fe9...45fec655c2e1